8000 Allow to opt-out from clearing cache on shutdown by Nyholm · Pull Request #69 · SymfonyTest/symfony-bundle-test · GitHub
[go: up one dir, main page]
Skip to content

Allow to opt-out from clearing cache on shutdown #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 4, 2022
Merged

Allow to opt-out from clearing cache on shutdown #69

merged 5 commits into from
Apr 4, 2022
+22 −1

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Apr 3, 2022

No description provided.

@Nyholm Nyholm requested a review from chapterjason April 3, 2022 09:51
@Nyholm
Copy link
Member Author
Nyholm commented Apr 3, 2022

We could also do a protected property

@chapterjason
Copy link
Contributor

@Nyholm I think it would be better to create a configurable Property as you suggested, this would end up with a better DX. The shutdown will be called automatically from the KernelTestCase

@Nyholm
Copy link
Member Author
Nyholm commented Apr 4, 2022

I've updated the PR.

jdreesen
jdreesen reviewed Apr 4, 2022
View reviewed changes
@Nyholm @jdreesen
Update src/TestKernel.php
b2781be 
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
@Nyholm Nyholm merged commit a94d540 into master Apr 4, 2022
@Nyholm
Copy link
Member Author
Nyholm commented Apr 4, 2022

Thank you

@Nyholm Nyholm deleted the clear-cache branch April 4, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen left review comments

@chapterjason chapterjason chapterjason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @chapterjason @jdreesen
0