8000 Fix method signatures for legacy compatibility by fransweerts · Pull Request #7 · SymfonyCasts/dynamic-forms · GitHub
[go: up one dir, main page]
Skip to content

Fix method signatures for legacy compatibility #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix method signatures for legacy compatibility #7

merged 1 commit into from
Sep 22, 2023

Conversation

fransweerts
Copy link

Fixes #5

@fransweerts fransweerts mentioned this pull request Sep 13, 2023
Closed
This was referenced Sep 13, 2023
Closed
Merged
@weaverryan
Copy link
Contributor

Thank you Frans!

@weaverryan weaverryan merged commit dae0100 into SymfonyCasts:main Sep 22, 2023
weaverryan added a commit that referenced this pull request Oct 9, 2023
@weaverryan
minor #8 Allow symfony/twig-bundle ^5.4 to better test lowest deps (b…
e50c06f 
…ocharsky-bw)

This PR was squashed before being merged into the main branch.

Discussion
----------

Allow symfony/twig-bundle ^5.4 to better test lowest deps

In order to prevent regression and catch #5 with tests... needed to be rebased on #7 to make tests pass.

Seems we also need to add `"symfony/options-resolver": "^5.4|^6.3|^7.0"` to the dev deps to fix deprecations

Commits
-------

dd5607b Allow symfony/twig-bundle ^5.4 to better test lowest deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symfonycasts\DynamicForms\DynamicFormBuilder::add is not compatible with Symfony\Component\Form\FormBuilderInterface::add
3 participants
@fransweerts @weaverryan @bocharsky-bw
0