Fix ShopBasedCartContext resetting #9613
Conversation
|
Thank you, Dimosthenis! 🎉 Don't hesitate to share your findings about running Sylius in PHP-PM :) |
|
Although it could use some quick unit test, I'll try to prepare one. |
|
Thank you! I wasn't sure how to unit test this part. So far it seems to be working great and fast with PHP-PM after this and #9608 :) It will go for user testing in the next few weeks, so I'll be happy to make PR for any other issues we find running it this way. |
|
Awesome to hear that! Added some tests for that new method in #9617. |
|
@dnna Are you using PHP-PM with or without Docker? I've done some testing with nginx setup and it seems to be mind-blowing! |
|
@czende I'm using it with Docker. The performance gain is pretty insane, but there are unfortunately some hard-to-fix leaks (see #9629) especially in the admin that cause inconsistent behavior. The shop front-end seems quite stable and I haven't noticed any issues there since merging this PR. All in all I'd say its not production ready yet, but its closer than I expected! |
ShopBasedCartContext keeps an instance of the cart internally. When using PHP-PM, this attribute needs to be reset at the end of each request otherwise unexpected behaviors happen. This solution uses the kernel.reset tag introduced specifically for this purpose in symfony/symfony#23984