Show autoload changes in readme for upgrade beta3 -> 1.0 (fixes #8564) #8565
Conversation
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #8564 |
| License | MIT |
|
The only thing that disturbs me is how does it work for the Symfony versions below 3.3.8? |
|
Good one, I actually have no clue. This is the commit in Symfony-Standard. I interpreted it as that it's only included in 3.3.8: symfony/symfony-standard@298f8b2. So that means that before 3.3.8, the app/autoload would still exist and I guess required. Maybe that's also good to note in the Upgrade guide then. Or, should we require Symfony ^3.3.8 instead of ^3.3.6? |
|
But that's 3.3.8 from Symfony-Standard. I think this is the one related that's in 3.3: symfony/symfony#21837. |
|
@lchrusciel Adjusted text to make users only do this when on Symfony ^3.3.8. |
|
I suppose that current changes force us to use symfony 3.3.8 anyway, so maybe the comment won't be needed. Let's wait until tomorrow for others /cc @Sylius/core-team |
UPGRADE.md
Outdated
| autoloader. Apply the following changes (reference: https://github.com/Sylius/Sylius/pull/8340): | ||
|
|
||
| * Remove `app/autoload.php` | ||
| * Change autoload path in `bin/console`: replace 'vendor' with 'app' |
There was a problem hiding this comment.
I think you meant the other way around? :)
There was a problem hiding this comment.
Wow, haha, indeed :)
|
Closing in favour of #8576 |
|
Sorry, not this one :) |
|
Feedback fixed. |
|
Thank you Stefan! 👍 |