8000 Product list locale fallback by tomkalon · Pull Request #18584 · Sylius/Sylius · GitHub
[go: up one dir, main page]
Skip to content

Product list locale fallback #18584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tomkalon wants to merge 2 commits into
base: 2.2
Choose a base branch
from
Draft

Product list locale fallback #18584

tomkalon wants to merge 2 commits into from

Conversation

@tomkalon
Copy link
Contributor
@tomkalon tomkalon commented Nov 26, 2025 •
edited
Loading
Q A
Branch? 2.2
Bug fix? no
New feature? yes
BC breaks? no
Related tickets #18566
License MIT

Translations appear, but there is a problem with sorting.
BTW - in the absence of translations, there are more queries to the database (the problem occurred before the fix).

@tomkalon
Add fallbackLocale to ProductRepository::createListQueryBuilder and a…
1812561 
…dapt related grid and tests

- Updated `ProductRepositoryInterface` and `ProductRepository` to include `fallbackLocale` parameter in `createListQueryBuilder`.
- Modified product grid configuration to support `fallbackLocale`.
- Adjusted Behat scenarios to reflect fallback logic for sorting products with missing translations.
@tomkalon tomkalon requested review from a team as code owners November 26, 2025 12:25
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Nov 26, 2025
@coderabbitai
Copy link
coderabbitai bot commented Nov 26, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
github-actions bot commented Nov 26, 2025 •
edited
Loading

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Check https://github.com/Sylius/Sylius/actions/runs/19737022593 for details.

Available commands:

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@Rafikooo Rafikooo linked an issue Nov 27, 2025 that may be closed by this pull request
[Admin] Product taxon grid table is empty if admin locale doesn't match content locale (en instead of en_US) #18566
Open
@tomkalon tomkalon force-pushed the feature/product-list-locale-fallback branch from 62c4c2b to e3cc8ef Compare November 27, 2025 10:43
@tomkalon
Remove failing scenarios for sorting products by missing translations
ae9c255 
- Deleted redundant and failing Behat scenarios related to sorting products with missing translations.
- Simplified `managing_products/sorting_products.feature`.
@tomkalon tomkalon force-pushed the feature/product-list-locale-fallback branch from e3cc8ef to ae9c255 Compare November 27, 2025 12:56
@Rafikooo Rafikooo marked this pull request as draft December 11, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Admin AdminBundle related issues and PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Admin] Product taxon grid table is empty if admin locale doesn't match content locale (en instead of en_US)

1 participant

@tomkalon
0