Correctly urlencode path in setcookie(); refix Studio-42#3538 #3754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some characters are valid in URLs but not in cookies, eg. comma or semicolon. They needs to be encoded properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some characters are valid in URLs but not in cookies, eg. comma or semicolon. They needs to be encoded properly.
This is the same as issue #3538
It was fixed by #3561
Then the change was reverted in #3619
I'm not sure about the problem fixed by #3619, as there's no related issue or explanation on the change.
Still, the original problem of #3528 reappeared, so I'm submitting the fix again.