[pull] main from google:main #100
Open
+16,718
−1,664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 767197024
PiperOrigin-RevId: 767202237
None: PiperOrigin-RevId: 767204150
- Add missing override. - Add warning to failed actions. - Remove unused import. - Remove unused fields. - Add type checking. PiperOrigin-RevId: 767209697
PiperOrigin-RevId: 767218068
PiperOrigin-RevId: 767225493
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reviewer's GuideThis PR prepares the 1.2.0 release by updating the changelog and version, refactors artifact forwarding in the agent tool, strengthens session services with improved error handling and logging, extends testing coverage, and introduces new LocalEvalSetResultsManager tests. Sequence Diagram: ForwardingArtifactService - Save ArtifactsequenceDiagram
participant Client as "Client (e.g. Runner)"
participant fas as ForwardingArtifactService
participant tc as ToolContext
Client->>fas: save_artifact(filename, artifact)
note right of fas: app_name, user_id, session_id from call are used
fas->>tc: save_artifact(filename, artifact)
tc-->>fas: artifact_id
fas-->>Client: artifact_id
Sequence Diagram: ForwardingArtifactService - Delete ArtifactsequenceDiagram
participant Client as "Client (e.g. Runner)"
participant fas as ForwardingArtifactService
participant ic as "_InvocationContext (via ToolContext)"
participant parentAS as "Parent's BaseArtifactService (via _InvocationContext)"
Client->>fas: delete_artifact(app, user, session, filename)
note right of fas: Parameters app, user, session from call are ignored.
fas->>ic: Access parent context (app_name, user_id, session_id, artifact_service)
ic-->>fas: Returns parent context details & parentAS
fas->>parentAS: delete_artifact(parent_app_name, parent_user_id, parent_session_id, filename)
parentAS-->>fas:
fas-->>Client:
Class Diagram: AgentTool Artifact Handling RefactorclassDiagram
class BaseArtifactService {
<<Interface>>
+save_artifact()
+load_artifact()
+list_artifact_keys()
+delete_artifact()
+list_versions()
}
class ForwardingArtifactService {
-tool_context: ToolContext
-_invocation_context: _InvocationContext
+__init__(tool_context: ToolContext)
+save_artifact(filename, artifact)
+load_artifact(filename, version)
+list_artifact_keys()
+delete_artifact(filename)
+list_versions(filename)
}
class ToolContext {
#_invocation_context: _InvocationContext
+save_artifact(filename, artifact)
+load_artifact(filename, version)
+list_artifacts()
}
class AgentTool {
+run_async(tool_input, tool_context)
}
class _InvocationContext {
+artifact_service: BaseArtifactService
+app_name: str
+user_id: str
+session: Session
}
ForwardingArtifactService --|> BaseArtifactService : implements
ForwardingArtifactService o-- ToolContext : uses
AgentTool ..> ForwardingArtifactService : instantiates in run_async
ToolContext o-- _InvocationContext : contains
ForwardingArtifactService ..> _InvocationContext : accesses for delete/list_versions
Class Diagram: Session Service UpdatesclassDiagram
class VertexAiSessionService {
+__init__(project, location) // API client management refactored (obtained per-method)
+create_session() // Added LRO polling, retry & timeout logic
+delete_session() // Added error logging (try-except)
#_convert_event_to_json(event: Event) : Dict~str, Any~ // Return type hint updated
#_from_api_event(api_event: Dict~str, Any~) : Event // Return type hint updated
}
class InMemorySessionService {
+delete_session() // Added @override, return behavior clarified
+append_event() // Added warning logs for missing session/app/user
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Fixes #1125 and add it to pyproject.toml. This was added to typing_extensions in 4.5.0. I followed versioning guidance from https://typing-extensions.readthedocs.io/en/latest/index.html#versioning-and-backwards-compatibility. PiperOrigin-RevId: 767317467
PiperOrigin-RevId: 767338013
add a ADK triaging agent to help triaging issues. This is an MVP. We can iterate further.
…ute in agent loader PiperOrigin-RevId: 767447874
…ackage PiperOrigin-RevId: 767697759
PiperOrigin-RevId: 767701441
PiperOrigin-RevId: 767710673
Partial fix for #1170 TODOs: - UI rendering still has issue to match the event with the correct agent. - graph building needs further fix when there is a workflow agent in the tree. PiperOrigin-RevId: 767711701
PiperOrigin-RevId: 767732597
PiperOrigin-RevId: 767747328
Fixes #643 PiperOrigin-RevId: 767788472
PiperOrigin-RevId: 767829097
PiperOrigin-RevId: 767843229
…pection PiperOrigin-RevId: 767926726
PiperOrigin-RevId: 768124459
the original code passed in wrong args. now fixed. tested locally. PiperOrigin-RevId: 773108589
PiperOrigin-RevId: 773128206
given it was not correctly supported. PiperOrigin-RevId: 773137317
PiperOrigin-RevId: 773140021
PiperOrigin-RevId: 773148349
This change accepts the `google.auth.credentials.Credentials` type for `BigQueryCredentialsConfig`, so any subclass of that, including `google.oauth2.credentials.Credentials` would work to integrate with BigQuery service. This opens up a whole range of possibilities, such as using service account credentials to deploy an agent using these tools. PiperOrigin-RevId: 773190440
PiperOrigin-RevId: 773785385
PiperOrigin-RevId: 773795427
… client Fixes #1514 PiperOrigin-RevId: 773838035
PiperOrigin-RevId: 773867075
Also reorganize the fast_api_common_options. This resolves #1444. PiperOrigin-RevId: 773890111
PiperOrigin-RevId: 773894462
…unction call if user m B41A essage is a function response PiperOrigin-RevId: 773895971
PiperOrigin-RevId: 774827874
Merge #1079 Fixes part of #356 Add usage attributes to span. Note: Since the handling of GenAI event bodies in OpenTelemetry has not yet been determined, I have temporarily added only attributes related to usage. COPYBARA_INTEGRATE_REVIEW=#1079 from soundTricker:feature/356-support-more-opentelemetry-semantics 99a9d03 PiperOrigin-RevId: 774834279
Merge #1451 ## Description Fixes #1306 by using `async for` with `await self.llm_client.acompletion()` instead of synchronous `for` loop. ## Changes - Updated test mocks to properly handle async streaming by creating an async generator - Ensured proper parameter handling to avoid duplicate stream parameter ## Testing Plan - All unit tests now pass with the async streaming implementation - Verified with `pytest tests/unittests/models/test_litellm.py` that all streaming tests pass - Manually tested with a sample agent using LiteLLM to confirm streaming works properly # Test Evidence: https://youtu.be/hSp3otI79DM Let me know if you need anything else from me for this PR COPYBARA_INTEGRATE_REVIEW=#1451 from avidelatm:fix/litellm-async-streaming d35b9dc PiperOrigin-RevId: 774835130
PiperOrigin-RevId: 774878336
…functions.py PiperOrigin-RevId: 774880990
…ecify GCS bucket to store eval data PiperOrigin-RevId: 774947795
… RougeEvaluator that is computes ROUGE-1 for "response_match_score" metric PiperOrigin-RevId: 774949712
PiperOrigin-RevId: 775317848
…FastAPI endpoint PiperOrigin-RevId: 775327151
Add examples for for #1273 PiperOrigin-RevId: 775352677
PiperOrigin-RevId: 775394737
…given their default value is None PiperOrigin-RevId: 775397286
The intended behavior for include_contents='none' is to: - Exclude conversation history from previous turns - Still include current turn context (user input, tool calls/responses within current turn) https://google.github.io/adk-docs/agents/llm-agents/#managing-context-include_contents This resolves #1124 PiperOrigin-RevId: 775400036
Merge #1547 This PR replaces the `curl`-based installation of `uv` to instead use the [official GitHub Action from Astral](https://github.com/astral-sh/setup-uv). Closes #1545 COPYBARA_INTEGRATE_REVIEW=#1547 from d33bs:use-uv-action 05ab7a1 PiperOrigin-RevId: 775402484
PiperOrigin-RevId: 775423356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Prepare v1.2.0 release with new features, bug fixes, and core service enhancements.
New Features:
Bug Fixes:
Enhancements:
CI:
Documentation:
Tests:
Chores:
adk webandadk api_server