8000 SQSCANGHA-94 Update version update logic by csaba-feher-sonarsource · Pull Request #188 · SonarSource/sonarqube-scan-action · GitHub
[go: up one dir, main page]

Skip to content

SQSCANGHA-94 Update version update logic #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

csaba-feher-sonarsource
Copy link
Contributor
@csaba-feher-sonarsource csaba-feher-sonarsource commented May 1, 2025

SQSCANGHA-94

Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".

With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Make sure any code you changed is covered by tests
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (SONAR-XXXX)

We will try to give you feedback on your contribution as quickly as possible.

Thank You!
The SonarSource Team

Copy link
Member
@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how it is helping the original concern of using write permission, but at least this is a nice refactoring, makes things cleaner.

@csaba-feher-sonarsource csaba-feher-sonarsource changed the title SQSCANGHA-89 Update version update logic SQSCANGHA-94 Update version update logic May 5, 2025
@csaba-feher-sonarsource csaba-feher-sonarsource force-pushed the task/cfeher/SQSCANGHA-89-Fix-version-upgrade branch from ab84207 to d7e162a Compare May 5, 2025 14:50
@csaba-feher-sonarsource csaba-feher-sonarsource merged commit 73bc64c into master May 5, 2025
56 checks passed
@csaba-feher-sonarsource csaba-feher-sonarsource deleted the task/cfeher/SQSCANGHA-89-Fix-version-upgrade branch May 5, 2025 15:48
luketainton pushed a commit to luketainton/roboluke-tasks that referenced this pull request May 6, 2025
…0 (#349)

This PR con
7CA0
tains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v5.1.0` -> `v5.2.0` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v5.2.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v5.2.0)

[Compare Source](SonarSource/sonarqube-scan-action@v5.1.0...v5.2.0)

##### What's Changed

-   SQSCANGHA-90 remove mend dead conf by [@&#8203;pierre-guillot-gh](https://github.com/pierre-guillot-gh) in SonarSource/sonarqube-scan-action#184
-   SQSCANGHA-89 Attempt to fix command injection by [@&#8203;henryju](https://github.com/henryju) in SonarSource/sonarqube-scan-action#186
-   SQSCANGHA-93 Fix madhead/semver-utils' version by [@&#8203;csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#187
-   SQSCANGHA-94 Update version update logic by [@&#8203;csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#188
-   SQSCANGHA-92 Validate scanner version by [@&#8203;csaba-feher-sonarsource](https://github.com/csaba-feher-sonarsource) in SonarSource/sonarqube-scan-action#189

**Full Changelog**: SonarSource/sonarqube-scan-action@v5...v5.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4wLjkiLCJ1cGRhdGVkSW5WZXIiOiI0MC4wLjkiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbInR5cGUvZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/349
Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0