8000 R113 follow up by rcj-siteimprove · Pull Request #1592 · Siteimprove/alfa · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R113 follow up #1592

Merged
merged 21 commits into from
Apr 5, 2024
Merged

R113 follow up #1592

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
98311f9
Split outcomes
rcj-siteimprove Apr 2, 2024
86d1ebf
Implement spacing detection correctly
rcj-siteimprove Apr 2, 2024
d365a57
Add changesets
rcj-siteimprove Apr 2, 2024
dc85f05
Fix changeset wording
rcj-siteimprove Apr 2, 2024
8638a07
Merge branch 'main' into r113-follow-up
rcj-siteimprove Apr 2, 2024
1fc2e1e
Sort imports
rcj-siteimprove Apr 2, 2024
fd001e3
Add ASCII art documentation
rcj-siteimprove Apr 3, 2024
40d3776
Add tests of circle-rectangle intersection
rcj-siteimprove Apr 4, 2024
d2bfa8d
Use Either for conditions
rcj-siteimprove Apr 4, 2024
89cc879
Move intersection logic to alfa-rectangle
rcj-siteimprove Apr 4, 2024
bdf7c07
Collect too close neighbors and send in diagnostic
rcj-siteimprove Apr 4, 2024
db42740
Use interfaces instead of inline types
rcj-siteimprove Apr 4, 2024
d40a78b
Update warm-tools-return.md
rcj-siteimprove Apr 4, 2024
9749191
Update ASCII drawing
rcj-siteimprove Apr 4, 2024
8f8448a
Add changeset for alfa-rectangle
rcj-siteimprove Apr 4, 2024
35019d4
Extract API
github-actions[bot] Apr 4, 2024
bd154c1
Remove @link tag, it appears not to be allowed for file paths
rcj-siteimprove Apr 4, 2024
c28634e
Add reference from alfa-rules to alfa-either
rcj-siteimprove Apr 4, 2024
948fab6
Apply suggestions from code review
rcj-siteimprove Apr 5, 2024
65b7911
Refactor expectation
rcj-siteimprove Apr 5, 2024
1061bbf
Extract API
github-actions[bot] Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Extract API
  • Loading branch information
@github-actions
github-actions[bot] committed Apr 5, 2024
commit 1061bbfd77133dd5d4604a52a38750e4a3c2beb5
2 changes: 0 additions & 2 deletions docs/review/api/alfa-rectangle.api.md
View file
Open in desktop
821F
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export class Rectangle implements Equatable, Hashable, Serializable<Rectangle.JS
};
// (undocumented)
contains(other: Rectangle): boolean;
// (undocumented)
distanceSquared(other: Rectangle): number;
// (undocumented)
static empty(): Rectangle;
Expand All @@ -41,7 +40,6 @@ export class Rectangle implements Equatable, Hashable, Serializable<Rectangle.JS
intersection(other: Rectangle): Rectangle;
// (undocumented)
intersects(other: Rectangle): boolean;
// (undocumented)
intersectsCircle(cx: number, cy: number, r: number): boolean;
// (undocumented)
isEmpty(): boolean;
Expand Down
0