Improve alias parsing in the cst & ast #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alok Swamy <alok.swamy@shopify.com>
8988b17 to
67f029f
Compare
67f029f to
750a754
Compare
jamesmengo
reviewed
Mar 11, 2025
| variable: ConcreteRenderVariableExpression | null; | ||
| aliasExpression: ConcreteRenderAliasExpression | null; |
There was a problem hiding this comment.
can we keep this as-is?
jamesmengo
reviewed
Mar 11, 2025
| @@ -388,6 +389,11 @@ export interface ConcreteRenderVariableExpression | |||
| name: ConcreteLiquidExpression; | |||
| } | |||
|
|
|||
| export interface ConcreteRenderAliasExpression | |||
| extends ConcreteBasicNode<ConcreteNodeTypes.RenderAliasExpression> { | |||
| alias: string; | |||
There was a problem hiding this comment.
If we keep alias in ConcreteLiquidTagRenderMarkup, we can make this .value
jamesmengo
reviewed
Mar 11, 2025
| @@ -183,7 +183,7 @@ function printNamedLiquidBlockStart( | |||
| case NamedTags.render: { | |||
| const markup = node.markup; | |||
| const trailingWhitespace = | |||
| markup.args.length > 0 || (markup.variable && markup.alias) ? line : ' '; | |||
| markup.args.length > 0 || (markup.variable && markup.aliasExpression?.alias) ? line : ' '; | |||
There was a problem hiding this comment.
Does this condition need to be updated?
When would markup.aliasExpression be truthy but markup.aliasExpression?.alias be falsy?
There was a problem hiding this comment.
Based off the types in stage-1, I would expect aliasExpression to be null
|
This is going in the right direction! Left some questions / comments :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Closes: https://github.com/Shopify/developer-tools-team/issues/607
RenderAliasExpressionnode type.asandwithpart of render tagsBefore you deploy
changeset