This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Update HadExceptions if socket not connected#186
Merged
mythz merged 1 commit intoServiceStack:v3from Nov 6, 2013
jeffgabhart:joplaal
Merged
Update HadExceptions if socket not connected#186mythz merged 1 commit intoServiceStack:v3from jeffgabhart:joplaal
mythz merged 1 commit intoServiceStack:v3from
jeffgabhart:joplaal
Conversation
When ConnectTimeout != 0, it does not throw the exception, and HadExceptions it is not updated. Due to that, the connection is not disposed and the pool can not recover after a server crash
mythz
added a commit
that referenced
this pull request
Nov 6, 2013
Update HadExceptions if socket not connected
Member
|
Awesome, thx Jeff 👍 FYI: I just deployed the latest v3 this weekend, so the next 1 will be in another fortnight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ConnectTimeout != 0, it does not throw the exception, and
HadExceptions it is not updated. Due to that, the connection is not
disposed and the pool can not recover after a server crash
v3 commit of #184