8000 [java] Remove deprecated AppCacheStatus enum from the HTML5 package by iampopovich · Pull Request #15973 · SeleniumHQ/selenium · GitHub
[go: up one dir, main page]
Skip to content

[java] Remove deprecated AppCacheStatus enum from the HTML5 package #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 5, 2025
Merged

[java] Remove deprecated AppCacheStatus enum from the HTML5 package #15973

merged 4 commits into from
Jul 5, 2025

Conversation

iampopovich
Copy link
Contributor
@iampopovich iampopovich commented Jun 28, 2025 •
edited by qodo-merge-pro bot
Loading

User description

🔗 Related Issues

partially fixes #10397

💥 What does this PR do?

This pull request removes the AppCacheStatus enum from the Selenium codebase. The enum was deprecated and represented the application cache status, which is no longer relevant due to the deprecation of the AppCache API in modern browsers.

Code removal:

  • java/src/org/openqa/selenium/html5/AppCacheStatus.java: Deleted the AppCacheStatus enum, including its values (UNCACHED, IDLE, CHECKING, DOWNLOADING, UPDATE_READY, OBSOLETE), associated methods (value, getEnum), and annotations (@Deprecated, @NullMarked). This change reflects the removal of outdated functionality tied to the deprecated AppCache API.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Breaking changes

PR Type

Other

Description

  • Remove deprecated AppCacheStatus enum from HTML5 package

  • Remove deprecated app cache commands from DriverCommand interface

  • Clean up obsolete AppCache API functionality

Changes diagram

flowchart LR
  A["AppCacheStatus enum"] -- "deleted" --> B["Removed"]
  C["DriverCommand constants"] -- "removed GET_APP_CACHE & CLEAR_APP_CACHE" --> D["Cleaned up"]
Loading

Changes walkthrough 📝

Relevant files
Miscellaneous
AppCacheStatus.java
Delete entire AppCacheStatus enum file                                     

java/src/org/openqa/selenium/html5/AppCacheStatus.java

  • Complete removal of deprecated AppCacheStatus enum
  • Deleted all enum values (UNCACHED, IDLE, CHECKING, etc.)
  • Removed helper methods value() and getEnum()
    		• +0/-67   
    DriverCommand.java
    Remove app cache command constants                                             

    java/src/org/openqa/selenium/remote/DriverCommand.java

  • Removed GET_APP_CACHE constant
  • Removed CLEAR_APP_CACHE constant
    		• +0/-2     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added the C-java Java Bindings label Jun 28, 2025
    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor
    qodo-merge-pro bot commented Jun 28, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    diemol
    diemol approved these changes Jul 5, 2025
    View reviewed changes
    Copy link
    Member
    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you, @iampopovich!

    @diemol diemol merged commit 835066e into SeleniumHQ:trunk Jul 5, 2025
    32 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @diemol diemol diemol approved these changes

    Assignees
    No one assigned
    Labels
    C-java Java Bindings Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Remove HTML 5 functionality helper code
    3 participants
    @iampopovich @diemol @selenium-ci
    0