You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping of macOS Options key to right_shift and Function key to right_control should be validated to ensure these are the correct WebDriver key codes for macOS keyboard interactions. Consider if these mappings align with actual macOS key behavior and WebDriver specifications.
options: "\ue050",# macOS Options key, same as right_shiftfunction: "\ue051",# macOS Function key, same as right_control
✅ Fix incorrect macOS key mappingSuggestion Impact:The suggestion was directly implemented - the Options key mapping was changed from \ue050 to \ue052 as suggested
code diff:
- options: "\ue050", # macOS Options key, same as right_shift+ options: "\ue052",
The key mappings appear incorrect for macOS. The Options key should map to Alt/Option functionality, not right_shift, and the Function key has its own distinct behavior that shouldn't be aliased to right_control.
-options: "\ue050", # macOS Options key, same as right_shift+options: "\ue052", # macOS Options key, same as right_alt
function: "\ue051", # macOS Function key, same as right_control
[Suggestion processed]
Suggestion importance[1-10]: 8
__
Why: The suggestion correctly identifies that the macOS Options key is equivalent to the Alt key and should be mapped to right_alt (\ue052), not right_shift (\ue050). This is a valid and important correction to the key mapping logic.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
fixes #15945
💥 What does this PR do?
This pull request adds new key definitions to the
Keysmodule inrb/lib/selenium/webdriver/common/keys.rbto improve support for macOS-specific keys.Key additions:
optionskey definition ("\ue050") to represent the macOS Options key, which is equivalent toright_shift.functionkey definition ("\ue051") to represent the macOS Function key, which is equivalent toright_control.🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Add macOS-specific key mappings for Options and Function keys
Map Options key to right_shift and Function key to right_control
Improve macOS keyboard support in Ruby bindings
Changes walkthrough 📝
keys.rb
Add macOS Options and Function key mappingsrb/lib/selenium/webdriver/common/keys.rb
optionskey mapping ("\ue050") as alias for right_shiftfunctionkey mapping ("\ue051") as alias for right_control