Tag property on IPlottable #5185
Conversation
|
I think most users would get better results by handling this themselves, it's pretty easy to create a And tha
7440
t way you could implement things like pub-sub or whatever your application model wants more easily. You could also get real typing, a My main issue though, is if ScottPlot isn't supposed to do anything with the tag, then I don't think ScottPlot should be responsible for handling it. As an example of how this could get dicey, suppose we had a More generally, I think IPlottable is the wrong abstraction for users to develop appmodels around, and I think the WPF way of tags is also dubious in general. |
|
It also looks like you have some extra changes in here, I'm seeing a new InteractiveTrendline plottable? |
|
BRANCHING - yea, i did the InteractiveTrendLine work first (has its own PR). I branched off that work to do the Tag obj since InteractiveTrendLine is an IPlottable. Sadly, github doesn't offer much in the way of separating those concepts. The tag code is a branch off the tip of the trendLine code. Either branch/pr would fail to compile if the other wasn't approved. If we don't want the InteractiveTrendLine then we'd just edit this PR to remove that class. TAGGEDPLOTTABLE - while that saves a cast for accessing properties off the object, it does have the negative compromise that you can no longer ref check .Tag with your own object.
Both the cast and the compromise for ref access are minor. I'm fine with going either way. Given you've got the yellow name i think i'll just say 'which one do ya want?' 🙂 as for naming.. i'm new to scottPlot.. is there any other area that you'd think would benefit from a Tag obj? If so then perhaps a more generic wrapper name would be better since the wrapper wouldn't expose any new members specific to Plottable objs. |
Added a new property to IPlottable:
public object Tag {get; set;}This Tag property is consistently available across WPF UI objects to allow consumers to add additional data objects to the UI.
wpf documentation
My specific use case was i allow the user to create trend lines on a candlestick chart and i save them to a database. The Tag property lets me add my model to the UI object for direct association. The user may have many different charts for the same symbol (1min, 2min, 5min, 15min, etc) and the trend lines need to be synchronized across all charts of that symbol. The common Tag property saves me from having to create more tedious mapping tables for each chart.