10BC0 Change the visibility of the FillStyle back to public by jurihock · Pull Request #5126 · ScottPlot/ScottPlot · GitHub
[go: up one dir, main page]
Skip to content

Change the visibility of the FillStyle back to public #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jurihock wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change the visibility of the FillStyle back to public D3FB #5126

jurihock wants to merge 1 commit into from
+1 −1

Conversation

@jurihock
Copy link
@jurihock jurihock commented Oct 19, 2025

Please change the visibility of the FillStyle property back to public, as it was before the commit 2642eef.

The LineStyle property is already public, which allows the library user to customise the border line color.
The same should also apply to the FillStyle.

public class ZoomRectangle(Plot plot) : IZoomRectangle
{
    public FillStyle FillStyle { get; set; } = new() // new: this should be public too
    {
        Color = new Color(255, 0, 0).WithAlpha(100),
        AntiAlias = false,
    };

    public LineStyle LineStyle { get; set; } = new() // this is already public
    {
        Color = new Color(255, 0, 0).WithAlpha(200),
        Width = 1,
        AntiAlias = false,
    };
}

See also: How to change the color of ZoomRectangle? #4690

@jurihock jurihock mentioned this pull request Oct 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jurihock
0