-
Notifications
You must be signed in to change notification settings - Fork 976
Barebones Avalonia 3D plot #5067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@swharden This is mostly just my experimentation branch (I had to port it to avalonia because I'm working on a Mac right now). I've moved it over to use explicit matrix multiplications because that's easier for my brain, but it's mostly the same save for me moving things into the ScottPlot.ScottPlot3D namespace. The existing WinForms code is untouched. I have found that keyboard rotation controls are a lot easier than mouse drag, since if the scene is rotated such that positive z is to the right dragging up should still rotate in whatever axis is perpendicular to screen up. Whereas with keyboard controls having w always correspond to positive Y rotation is less jarring. I think we should fix mouse controls, but the math for that isn't coming to me at the moment. |
|
Hey @bclehmann, I'd like to follow-up on this. There's a great amount of progress here. The build errors are just because warnings are treated as errors. Do you recommend I merge this now, and it gets deployed with the next release? I see all the new classes are in the ScottPlot3D namespace, and that's fine with me to include/publish WIP, I just want confirmation from you that this is good to merge. Thanks! |
|
Yeah as you can see this hasn't moved much in a while, I think the main problems are controlling the scene placement programmatically, as this doesn't have you adjust the camera position so much as a weird scene-like position for a stationary camera. I think that's confusing. And then camera controls I think will need work, but that can be done later. If you merge it in it's current state (I'll mark it ready for review so you can) I think this doesn't get rid of the 3D plots in the WinForms project, so I'd probably axe those so we don't have this in multiple places. I would definitely not put it in the next release as a public API, I think it's fine if it's marked internal or with some very heavy-handed "This is experimental" warnings, since the whole thing is likely to change. |
|
fwiw I would be very interested in trying to use this in my Kusto-Loco project, even if experimental status, if it makes it into a release. |
Use this space to describe what this pull request accomplishes.
Refer to open issues by their number to help link them with this pull request.
Consider including screenshots or code samples if it would help communicate the purpose of this pull request.