Support the multiple inputs of keras model.fit. #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oceania2018
reviewed
Mar 4, 2023
Oceania2018
reviewed
Mar 4, 2023
Oceania2018
reviewed
Mar 4, 2023
| @@ -20,7 +21,7 @@ public TensorLikeDataAdapter(DataAdapterArgs args) | |||
| { | |||
| this.args = args; | |||
| _process_tensorlike(); | |||
| num_samples = (int)args.X.shape[0]; | |||
| num_samples = (int)args.X[0].shape[0]; | |||
There was a problem hiding this comment.
Can we use (int)args.X.shape[0] instead of (int)args.X[0].shape[0]?
There was a problem hiding this comment.
Sure, I have changed it.
This was referenced Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #939
It mainly did two things:
model.fit.anonymous_iterator_v2toanonymous_iterator_v3.It made the following break changes:
ArraytoNDArray. Instead, it added a series implicit conversion such asint[],float[,],double[,,]and so on.IDatasetV2implementsIEnumerable<(Tensors, Tensors)>instead ofIEnumerable<(Tensor, Tensor)>. (This may lead to some error of examples.)