8000 feat: make deprecated `ODESystem` alias `System` type by AayushSabharwal · Pull Request #3806 · SciML/ModelingToolkit.jl · GitHub
[go: up one dir, main page]

Skip to content

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@asinghvi17
Copy link
Contributor

Benchmark failure is either an API rate limit or the api key not having the right privileges


@testset "`ODESystem` is a type" begin
@variables x(t)
@named sys = ODESystem(D(x) ~ x, t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a @test_warns here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a depwarn test somewhere else

@AayushSabharwal AayushSabharwal merged commit 69142fa into SciML:master Jul 9, 2025
42 of 50 checks passed
@AayushSabharwal AayushSabharwal deleted the as/odesystem-type branch July 9, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0