Add simple GUI for sound capture example #3624
Open
+155
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf7451c to
9d44cd7
Compare
eXpl0it3r
requested changes
Jan 12, 2026
| if (!sf::SoundRecorder::isAvailable()) | ||
| { | ||
| std::cout << "Sorry, audio capture is not supported by your system" << std::endl; | ||
| sf::err() << "Sorry, audio capture is not supported by your system" << std::endl; |
Member
There was a problem hiding this comment.
sf::err() should generally speaking only be used by SFML itself
| const auto devices = sf::SoundRecorder::getAvailableDevices(); | ||
| if (devices.empty()) | ||
| { | ||
| sf::err() << "No sound recording devices available" << std::endl; |
Member
There was a problem hiding this comment.
Same here, either std::cout or std::cerr
| } | ||
|
|
||
| std::cout << "Available capture devices:\n" << std::endl; | ||
| sf::RenderWindow window(sf::VideoMode({800, 600}), "Sound capture example"); |
Member
There was a problem hiding this comment.
Maybe we could enable anti-aliasing
|
|
||
| // Audio capture is done in a separate thread, so we can block the main thread while it is capturing | ||
| if (!recorder.start(sampleRate)) | ||
| assert(index < devices.size()); |
Member
There was a problem hiding this comment.
Do asserts in an example make sense?
| // Display the playing position | ||
| std::cout << "\rPlaying... " << sound.getPlayingOffset().asSeconds() << " sec "; | ||
| std::cout << std::flush; | ||
| if (const auto* clickEvent = event->getIf<sf::Event::MouseButtonPressed>(); |
Member
There was a problem hiding this comment.
Consider MouseButtonReleased instead
| // Check if a device is selected | ||
| for (auto i = 0u; i < devices.size(); ++i) | ||
| { | ||
| if (deviceTexts[i].getGlobalBounds().contains(sf::Vector2f{clickEvent->position})) |
Member
There was a problem hiding this comment.
Transform the mouse position once at the start with window.mapCoordsToPixel(clientEvent->position)
0394846 to
187deeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current example is command line based which is no good for non-desktop platforms, this adds a simple GUI
Will help in testing/implementing sound capture on mobile devices (see #630)
Have lost the ability to specify a custom sample rate, and to save to a file, which I felt added more complexity than they are worth for the purposes of this example, but can add something for them if desired