8000 Add support for getting and setting window states with size overload by eXpl0it3r · Pull Request #3501 · SFML/SFML · GitHub
[go: up one dir, main page]
Skip to content

Add support for getting and setting window states with size overload #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
eXpl0it3r wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add support for getting and setting window states with size overload #3501

eXpl0it3r wants to merge 6 commits into F440 from

Conversation

@eXpl0it3r
Copy link
Member
@eXpl0it3r eXpl0it3r commented May 3, 2025 •
edited
Loading

Description

This is an alternative/extended API design for #3496.
Main description & discussion on the other PR

sf::WindowBase implements the following three functions:

  • setState(sf::State state)
  • setState(sf::State state, sf::Vector2u size)
  • sf::State getState()

@eXpl0it3r eXpl0it3r mentioned this pull request May 3, 2025
Draft
10 tasks
ChrisThrasher
ChrisThrasher reviewed Jun 8, 2025
View reviewed changes
@ChrisThrasher ChrisThrasher force-pushed the feature/set_states_with_size branch from 7f72379 to 9412d67 Compare June 8, 2025 17:09
@ChrisThrasher
Copy link
Member
ChrisThrasher commented Jun 8, 2025

I implemented setState on macOS.

@ChrisThrasher ChrisThrasher force-pushed the feature/set_states_with_size branch from 9412d67 to 4a88208 Compare June 8, 2025 17:14
@ChrisThrasher ChrisThrasher force-pushed the feature/set_states_with_size branch from 4a88208 to 12a4516 Compare June 8, 2025 17:24
@github-project-automation github-project-automation bot moved this to Planned in SFML 3.2.0 Jun 19, 2025
@eXpl0it3r eXpl0it3r added this to the 3.2 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisThrasher ChrisThrasher ChrisThrasher left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feature m:sfml-window

Projects

SFML 3.2.0
Status: Planned

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@eXpl0it3r @ChrisThrasher
0