minor symfony#17108 [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit d481dda329d1 · 2015-12-22T15:03:54.000+01:00
This PR was merged into the 2.3 branch. Discussion ---------- [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - phpunit reports: - before: `Memory: 430.91Mb` - after: `Memory: 21.26Mb` Commits ------- cb23212 [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM
diff --git a/src/Symfony/Component/Routing/Tests/Generator/Dumper/PhpGeneratorDumperTest.php b/src/Symfony/Component/Routing/Tests/Generator/Dumper/PhpGeneratorDumperTest.php
@@ -85,6 +85,10 @@ public function testDumpWithRoutes()
 
     public function testDumpWithTooManyRoutes()
     {
+        if (defined('HHVM_VERSION_ID')) {
+            $this->markTestSkipped('HHVM consumes too much memory on this test.');
+        }
+
         $this->routeCollection->add('Test', new Route('/testing/{foo}'));
         for ($i = 0; $i < 32769; ++$i) {
             $this->routeCollection->add('route_'.$i, new Route('/route_'.$i));
