8000 Add PreparedStatement::getBatchDataSize() function by mrylov · Pull Request #16 · SAP/odbc-cpp-wrapper · GitHub
[go: up one dir, main page]

Skip to content

Add PreparedStatement::getBatchDataSize() function#16

Merged
stefanuhrig merged 1 commit intoSAP:masterfrom
mrylov:master
Dec 21, 2020
Merged

Add PreparedStatement::getBatchDataSize() function#16
stefanuhrig merged 1 commit intoSAP:masterfrom
mrylov:master

Conversation

@mrylov
Copy link
Contributor
@mrylov mrylov commented Dec 21, 2020

No description provided.

@mrylov mrylov requested a review from stefanuhrig December 21, 2020 11:49
@CLAassistant
Copy link
CLAassistant commented Dec 21, 2020

CLA assistant check
All committers have signed the CLA.

std::size_t blockRow_;

/// The number of bytes required for the batch.
std::size_t dataSize_ = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency reasons, I'd initialize dataSize_ in method initialize().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@stefanuhrig stefanuhrig merged commit e3be85b into SAP:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0