Preallocate strings in a smarter way + add str.rmul #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongy
commented
May 3, 2019
| @@ -193,6 +198,11 @@ impl PyString { | |||
| } | |||
| } | |||
|
|
|||
| #[pymethod(name = "__rmul__")] | |||
| fn rmul(&self, val: PyObjectRef, vm: &VirtualMachine) -> PyResult<String> { | |||
| self.mul(val, vm) | |||
There was a problem hiding this comment.
Downside with this simple impl is that the raised TypeError shows the values swapped (As per the order of __mul__, not __rmul__).
On the other hand, the shown message (still?) doesn't match the one given by CPython, so we can be less pedantic about it.
b54e108 to
857a701
Compare
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
==========================================
+ Coverage 64.04% 64.06% +0.01%
==========================================
Files 89 89
Lines 14976 14982 +6
Branches 3341 3342 +1
==========================================
+ Hits 9592 9598 +6
Misses 3178 3178
Partials 2206 2206
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.