8000 Fix lib_update to support backslash by youknowone · Pull Request #6719 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Fix lib_update to support backslash #6719

Merged
youknowone merged 1 commit intoRustPython:mainfrom
youknowone:fix-lib-updater-win
Jan 13, 2026
Merged

Fix lib_update to support backslash #6719
youknowone merged 1 commit intoRustPython:mainfrom
youknowone:fix-lib-updater-win

Conversation

@youknowone
Copy link
Member
@youknowone youknowone commented Jan 13, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved cross-platform path handling for quick-upgrade so paths work consistently on Windows and Unix.
    • Clarified validation error messages to include the original input for easier diagnosis.
    • Preserved existing default output behavior when writing to standard output.

✏️ Tip: You can customize this high-level summary in your review settings.

@youknowone youknowone added the skip:ci Skip running the ci label Jan 13, 2026
@youknowone youknowone marked this pull request as ready for review January 13, 2026 09:54
@coderabbitai
Copy link
Contributor
coderabbitai bot commented Jan 13, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Normalizes quick-upgrade paths in scripts/lib_updater.py by replacing backslashes with forward slashes for cross-platform handling, relaxes the validation message to acknowledge both /Lib/ and \Lib\, and preserves Lib path extraction and stdout expansion while showing the original input in errors.

Changes

Cohort / File(s) Summary
Path normalization & validation
scripts/lib_updater.py		 Replace backslashes with forward slashes for --quick-upgrade input; relax/extend validation message to reference both /Lib/ and \Lib\ and echo the original input on error; continue extracting Lib path and preserving stdout expansion behavior.

Sequence Diagram(s)

(omitted — change is a small single-file path-handling update)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ShaharNaveh

Poem

🐇 I hopped along a file path bright,
Backslashes flipped to forward light,
Libs now found where pathways meet,
Cross-platform footsteps light and fleet,
A little rabbit's happy feat.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix lib_update to support backslash' directly relates to the main change: normalizing backslashes to forward slashes for cross-platform path support in the lib_updater script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9cbbd3 and e61955d.

📒 Files selected for processing (1)
  • scripts/lib_updater.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone removed the skip:ci Skip running the ci label Jan 13, 2026
@youknowone youknowone merged commit 4d7a289 into RustPython:main Jan 13, 2026
11 of 13 checks passed
@youknowone youknowone deleted the fix-lib-updater-win branch January 13, 2026 10:02
@coderabbitai coderabbitai bot mentioned this pull request Jan 14, 2026
Merged
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
@youknowone @terryluan12
fix lib_update backslash support (RustPython#6719)
0739543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone
0