8000 move `derive-impl` -> `crates/derive-impl` by ShaharNaveh · Pull Request #6263 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

move derive-impl -> crates/derive-impl #6263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 4 commits into from
Nov 15, 2025
Merged

move derive-impl -> crates/derive-impl #6263

youknowone merged 4 commits into from
Nov 15, 2025

Conversation

@ShaharNaveh
Copy link
Collaborator
@ShaharNaveh ShaharNaveh commented Nov 14, 2025 •
edited by coderabbitai bot
Loading

ref: #6214

Summary by CodeRabbit

  • Chores
    • Updated workspace configuration and adjusted an internal dependency reference to the new path to ensure consistent dependency resolution.
    • Removed an internal workspace member to streamline project organization and improve maintainability.

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Nov 14, 2025 •
edited
Loading

Walkthrough

Removed the derive-impl workspace member and updated the workspace dependency path for rustpython-derive-impl from derive-impl to crates/derive-impl in Cargo.toml.

Changes

Cohort / File(s) Summary
Workspace manifest
Cargo.toml		 Removed derive-impl from [workspace].members; changed workspace dependency rustpython-derive-impl path from derive-impl to crates/derive-impl in [workspace.dependencies]

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single-file manifest edits; check workspace member list and dependency path correctness.
  • Verify build and workspace resolution after path change.

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 In folders snug, a crate now sleeps,

Root no more — it softly creeps,
Paths adjusted, tidy and neat,
A hop, a nudge, the workspace complete.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: moving the derive-impl component to the crates/derive-impl directory path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a913127 and af36ec0.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh mentioned this pull request Nov 14, 2025
Open
16 tasks
@youknowone youknowone merged commit 6479a20 into RustPython:main Nov 15, 2025
13 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone
0