Fix cspell warning #5890
Fix cspell warning #5890
Conversation
WalkthroughThis change updates spell-checking directive comments across numerous source files, replacing instances of Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Clippy (1.86.0)error: failed to load source for dependency Caused by: Caused by: Caused by: ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
vm/src/builtins/str.rs (2)
2266-2269: Nit: consider grouping consecutive spell-checker directives.The two
spell-checker:disable-next-linecomments are fine, but you could collapse them into a single multi-line directive to reduce comment noise.
2284-2286: Same minor note on directive consolidation.Optional clean-up: merge these adjacent
spell-checker:disable-next-linecomments for brevity.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (48)
common/src/boxvec.rs(1 hunks)common/src/format.rs(1 hunks)common/src/linked_list.rs(1 hunks)common/src/lock/cell_lock.rs(1 hunks)common/src/os.rs(1 hunks)common/src/str.rs(1 hunks)example_projects/frozen_stdlib/src/main.rs(1 hunks)jit/src/instructions.rs(1 hunks)src/lib.rs(1 hunks)stdlib/build.rs(1 hunks)stdlib/src/compression.rs(1 hunks)stdlib/src/fcntl.rs(1 hunks)stdlib/src/grp.rs(1 hunks)stdlib/src/json/machinery.rs(1 hunks)stdlib/src/locale.rs(1 hunks)stdlib/src/mmap.rs(1 hunks)stdlib/src/overlapped.rs(1 hunks)stdlib/src/posixsubprocess.rs(1 hunks)stdlib/src/resource.rs(1 hunks)stdlib/src/select.rs(1 hunks)stdlib/src/socket.rs(1 hunks)stdlib/src/ssl.rs(1 hunks)stdlib/src/termios.rs(1 hunks)stdlib/src/tkinter.rs(1 hunks)vm/src/builtins/genericalias.rs(2 hunks)vm/src/builtins/str.rs(3 hunks)vm/src/builtins/super.rs(1 hunks)vm/src/bytes_inner.rs(1 hunks)vm/src/stdlib/ctypes.rs(1 hunks)vm/src/stdlib/ctypes/function.rs(1 hunks)vm/src/stdlib/errno.rs(1 hunks)vm/src/stdlib/marshal.rs(1 hunks)vm/src/stdlib/msvcrt.rs(1 hunks)vm/src/stdlib/nt.rs(1 hunks)vm/src/stdlib/os.rs(1 hunks)vm/src/stdlib/posix.rs(1 hunks)vm/src/stdlib/posix_compat.rs(1 hunks)vm/src/stdlib/pwd.rs(1 hunks)vm/src/stdlib/signal.rs(1 hunks)vm/src/stdlib/typevar.rs(1 hunks)vm/src/stdlib/typing.rs(1 hunks)vm/src/stdlib/winapi.rs(1 hunks)vm/src/stdlib/winreg.rs(1 hunks)vm/src/vm/setting.rs(1 hunks)vm/sre_engine/tests/tests.rs(1 hunks)wtf8/src/core_char.rs(1 hunks)wtf8/src/core_str_count.rs(1 hunks)wtf8/src/lib.rs(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.rs`: Follow the default rustfmt code style (`cargo fmt` to format) Always ...
**/*.rs: Follow the default rustfmt code style (cargo fmtto format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass,pymodule,pyfunction, etc.) when implementing Python functionality in Rust
📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)
List of files the instruction was applied to:
stdlib/build.rsexample_projects/frozen_stdlib/src/main.rscommon/src/linked_list.rscommon/src/str.rscommon/src/os.rsvm/src/stdlib/winreg.rsvm/sre_engine/tests/tests.rsvm/src/stdlib/msvcrt.rsstdlib/src/overlapped.rsstdlib/src/termios.rsstdlib/src/select.rsstdlib/src/posixsubprocess.rsvm/src/stdlib/ctypes.rsstdlib/src/compression.rsvm/src/stdlib/posix_compat.rscommon/src/boxvec.rsvm/src/builtins/super.rsvm/src/stdlib/winapi.rssrc/lib.rscommon/src/format.rswtf8/src/lib.rsvm/src/stdlib/typevar.rsjit/src/instructions.rsstdlib/src/mmap.rsstdlib/src/locale.rsstdlib/src/fcntl.rsvm/src/stdlib/signal.rsvm/src/stdlib/os.rsvm/src/bytes_inner.rsvm/src/builtins/genericalias.rsvm/src/stdlib/errno.rsvm/src/stdlib/posix.rscommon/src/lock/cell_lock.rsvm/src/builtins/str.rsvm/src/stdlib/pwd.rsstdlib/src/grp.rswtf8/src/core_char.rswtf8/src/core_str_count.rsstdlib/src/resource.rsvm/src/stdlib/typing.rsstdlib/src/json/machinery.rsvm/src/stdlib/nt.rsvm/src/stdlib/ctypes/function.rsvm/src/stdlib/marshal.rsvm/src/vm/setting.rsstdlib/src/socket.rsstdlib/src/tkinter.rsstdlib/src/ssl.rs
🧠 Learnings (30)
stdlib/build.rs (1)
Learnt from: arihant2math
PR: RustPython/RustPython#5790
File: build.rs:2-2
Timestamp: 2025-06-28T16:31:03.971Z
Learning: In Cargo build scripts (build.rs), the environment variable CARGO_CFG_TARGET_OS is guaranteed to exist and is automatically set by Cargo during the build process, making unwrap() safe to use when accessing this variable.
example_projects/frozen_stdlib/src/main.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: When testing Python code, always use RustPython instead of the standard `python` command
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
common/src/linked_list.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
common/src/os.rs (3)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Always run clippy to lint code (`cargo clippy`) before completing tasks. Fix any warnings or lints that are introduced by your changes
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: arihant2math
PR: RustPython/RustPython#5790
File: build.rs:2-2
Timestamp: 2025-06-28T16:31:03.971Z
Learning: In Cargo build scripts (build.rs), the environment variable CARGO_CFG_TARGET_OS is guaranteed to exist and is automatically set by Cargo during the build process, making unwrap() safe to use when accessing this variable.
vm/src/stdlib/winreg.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: When testing Python code, always use RustPython instead of the standard `python` command
vm/sre_engine/tests/tests.rs (4)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : The only acceptable modifications to test files are: 1. Removing `@unittest.expectedFailure` decorators and the upper TODO comments when tests actually pass 2. Adding `@unittest.expectedFailure` decorators when tests cannot be fixed
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : NEVER comment out or delete any test code lines except for removing `@unittest.expectedFailure` decorators and upper TODO comments in test files
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Always run clippy to lint code (`cargo clippy`) before completing tasks. Fix any warnings or lints that are introduced by your changes
vm/src/stdlib/msvcrt.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
stdlib/src/select.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
stdlib/src/posixsubprocess.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
vm/src/stdlib/ctypes.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
vm/src/stdlib/posix_compat.rs (6)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory
8000
management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration using #ifdef checks rather than providing fallback values for other platforms.
Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration rather than providing fallback values for other platforms.
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
Learnt from: arihant2math
PR: RustPython/RustPython#5790
File: build.rs:2-2
Timestamp: 2025-06-28T16:31:03.971Z
Learning: In Cargo build scripts (build.rs), the environment variable CARGO_CFG_TARGET_OS is guaranteed to exist and is automatically set by Cargo during the build process, making unwrap() safe to use when accessing this variable.
wtf8/src/lib.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Always run clippy to lint code (`cargo clippy`) before completing tasks. Fix any warnings or lints that are introduced by your changes
vm/src/stdlib/typevar.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
vm/src/stdlib/signal.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: When testing Python code, always use RustPython instead of the standard `python` command
vm/src/stdlib/os.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
vm/src/bytes_inner.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
vm/src/builtins/genericalias.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
vm/src/stdlib/errno.rs (3)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: When testing Python code, always use RustPython instead of the standard `python` command
vm/src/stdlib/posix.rs (7)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Always run clippy to lint code (`cargo clippy`) before completing tasks. Fix any warnings or lints that are introduced by your changes
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: When testing Python code, always use RustPython instead of the standard `python` command
Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration using #ifdef checks rather than providing fallback values for other platforms.
Learnt from: moreal
PR: RustPython/RustPython#5847
File: vm/src/stdlib/stat.rs:547-567
Timestamp: 2025-06-27T14:47:28.810Z
Learning: In RustPython's stat module implementation, platform-specific constants like SF_SUPPORTED and SF_SYNTHETIC should be conditionally declared only for the platforms where they're available (e.g., macOS), following CPython's approach of optional declaration rather than providing fallback values for other platforms.
common/src/lock/cell_lock.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
vm/src/builtins/str.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Always run clippy to lint code (`cargo clippy`) before completing tasks. Fix any warnings or lints that are introduced by your changes
stdlib/src/grp.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
stdlib/src/resource.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
vm/src/stdlib/typing.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
vm/src/stdlib/nt.rs (3)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: When testing Python code, always use RustPython instead of the standard `python` command
vm/src/stdlib/ctypes/function.rs (3)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: When testing Python code, always use RustPython instead of the standard `python` command
vm/src/stdlib/marshal.rs (2)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
stdlib/src/socket.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
stdlib/src/tkinter.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to Lib/test/**/*.py : Add a `# TODO: RUSTPYTHON` comment when modifications are made to tests in `Lib/test`
stdlib/src/ssl.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.851Z
Learning: Applies to **/*.rs : Use the macro system (`pyclass`, `pymodule`, `pyfunction`, etc.) when implementing Python functionality in Rust
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Check the WASM package and demo
- GitHub Check: Ensure compilation on various targets
- GitHub Check: Run snippets and cpython tests (windows-latest)
- GitHub Check: Run snippets and cpython tests on wasm-wasi
- GitHub Check: Run tests under miri
- GitHub Check: Run snippets and cpython tests (ubuntu-latest)
- GitHub Check: Check Rust code with rustfmt and clippy
- GitHub Check: Run rust tests (ubuntu-latest)
- GitHub Check: Run rust tests (windows-latest)
- GitHub Check: Run rust tests (macos-latest)
🔇 Additional comments (49)
vm/src/stdlib/posix_compat.rs (1)
1-1: Comment directive update looks goodSwitching to the unified
// spell-checker:disabledirective keeps tooling consistent and has no runtime impact.common/src/lock/cell_lock.rs (1)
1-1:Consistent spell-checker directive The new
// spell-checker:ignoreline is correct and doesn’t affect behavior. 👍vm/src/stdlib/errno.rs (1)
1-1: No-op comment change acknowledgedDirective rename only; nothing else to review.
stdlib/src/locale.rs (1)
1-1: Comment renaming acceptedMaintains consistency across the codebase; no functional impact.
vm/src/stdlib/os.rs (1)
1-1: Directive rename OKMatches the project-wide transition to
spell-checkercomments.vm/src/stdlib/pwd.rs (1)
1-1: Directive renamed tospell-checker– looks goodComment-only change, no effect on runtime or tooling.
stdlib/src/grp.rs (1)
1-1: Consistent spell-checker directive – LGTM
Matches the new repo convention; nothing else to address.vm/src/stdlib/nt.rs (1)
1-1: Comment update only – approvedNo functional code touched; clippy/fmt remain unaffected.
vm/src/stdlib/msvcrt.rs (1)
1-1: Spell-checker tag updated – OKPurely cosmetic; nothing further.
vm/src/stdlib/winreg.rs (1)
1-1: Directive rename verified – fineAligns with project-wide change; no additional feedback.
common/src/format.rs (1)
1-1: Comment directive looks correct
The switch to// spell-checker:ignoreis consistent with the codebase changes and has zero functional impact.common/src/boxvec.rs (1)
1-1: No-op comment update acknowledged
Directive renamed as expected; nothing else to note.stdlib/src/fcntl.rs (1)
1-1: Spelling directive aligned
Matches the new convention; implementation code untouched.vm/src/stdlib/typevar.rs (1)
1-1: Header comment updated correctly
Change is purely cosmetic; no runtime effect.vm/src/stdlib/typing.rs (1)
1-1: Consistent spell-checker header
Update is harmless and keeps tooling consistent.wtf8/src/lib.rs (1)
1-1: Directive name updated – LGTMSwitching to
spell-checker:disablealigns with the new convention and carries no runtime impact.wtf8/src/core_str_count.rs (1)
1-1: Consistent spell-checker directive – looks goodComment-only change; no further action required.
stdlib/src/compression.rs (1)
1-1: Comment update acknowledgedSpell-checker directive renamed; implementation unchanged.
vm/sre_engine/tests/tests.rs (1)
1-1: Directive rename acceptedPurely cosmetic change; tests remain unaffected.
vm/src/bytes_inner.rs (1)
1-1: Spell-checker directive updated – no issuesNo functional code touched.
common/src/os.rs (1)
1-1: Consistent spell-check directive nameHeader updated to
// spell-checker:disable. No functional impact. LGTM.wtf8/src/core_char.rs (1)
1-1: Consistent spell-check directive nameComment switched to
// spell-checker:disable. Change is purely cosmetic and correct.common/src/linked_list.rs (1)
1-1: Consistent spell-check directive nameStandardised spell-checker directive; code untouched. Looks good.
common/src/str.rs (1)
1-1: Consistent spell-check directive nameUpdated ignore directive to match new tooling; no other changes. ✔️
stdlib/build.rs (1)
1-1: Consistent spell-check directive nameHeader comment corrected; build script logic unchanged. All good.
stdlib/src/ssl.rs (1)
1-1: Consistent spell-checker directive – no functional impactThe swap from
// cspell:disableto// spell-checker:disableonly touches tooling comments and doesn’t affect compilation or runtime behavior. Looks good.vm/src/stdlib/posix.rs (1)
1-1: Consistent spell-checker directive adoptedDirective switched from
cspelltospell-checker; matches the new project-wide convention. No functional impact.stdlib/src/json/machinery.rs (1)
1-1: Updated comment onlySpell-checker directive renamed for consistency; nothing else changed.
stdlib/src/socket.rs (1)
1-1: Comment-only change acknowledgedDirective was switched to
spell-checker:disable; no runtime impact.
LGTM.vm/src/builtins/super.rs (1)
1-1: Comment-only change acknowledgedUpdated to
spell-checker:ignore cmeth; no functional impact.
LGTM.stdlib/src/overlapped.rs (1)
1-1: Comment-only change acknowledgedSwitched to
spell-checker:disable; implementation remains intact.
LGTM.vm/src/stdlib/winapi.rs (1)
1-1: Consistent spell-checker directive — looks goodComment-only change; implementation untouched.
stdlib/src/posixsubprocess.rs (1)
1-1: Consistent spell-checker directive — looks goodPure comment update; no functional impact.
stdlib/src/mmap.rs (1)
1-1: Consistent spell-checker directive — looks goodNo code behaviour altered.
vm/src/stdlib/ctypes.rs (1)
1-1: Consistent spell-checker directive — looks goodChange is comment-only.
vm/src/stdlib/ctypes/function.rs (1)
1-1: Consistent spell-checker directive — looks goodNothing beyond a comment tweak.
example_projects/frozen_stdlib/src/main.rs (1)
1-1: Updated spell-checker directive – looks goodPure comment change; runtime behavior untouched.
jit/src/instructions.rs (1)
1-1: Spell-checker comment standardized – OKNo functional impact on the JIT compiler.
vm/src/stdlib/marshal.rs (1)
1-1: Consistent spell-checker tag – approvedComment-only tweak; serialization logic unchanged.
stdlib/src/tkinter.rs (1)
1-1: Comment directive renamed – fineNo code modifications; Tkinter bindings unaffected.
vm/src/stdlib/signal.rs (1)
1-1: Directive switched tospell-checker– all goodSignal module behavior remains identical.
stdlib/src/termios.rs (1)
1-1: Spell-checker directive updated correctlyOnly the comment was altered; no functional impact.
stdlib/src/resource.rs (1)
1-1: Consistent directive renameChange is comment-only and aligns with the new convention.
stdlib/src/select.rs (1)
1-1: Comment update acknowledgedNo runtime effect; change is fine.
src/lib.rs (1)
245-246: Directive rename looks goodComment-level update; nothing else touched.
vm/src/vm/setting.rs (1)
39-45: Clean-up of spell-checker ignoresBoth comment updates are correct and non-functional.
vm/src/builtins/str.rs (1)
580-583: Comment directive looks good – no functional impact.The
// spell-checker:ignore cmpxchgannotation is correct and does not affect code behaviour.vm/src/builtins/genericalias.rs (2)
1-1: LGTM – comment directive updated.The switch from
cspelltospell-checkeris correct.
593-595: No issues – comment update only.The added ignore for
gaiterobjectis benign; underlying TODO remains unchanged.
Summary by CodeRabbit