8000 Cleanup match statement codegen by arihant2math · Pull Request #5700 · RustPython/RustPython · GitHub
[go: up one dir, main page]

Skip to content

Cleanup match statement codegen #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 18, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy
  • Loading branch information
arihant2math committed Apr 15, 2025
commit d44324d4d0d522df8e6b77151b996c50bdd8d348
2 changes: 1 addition & 1 deletion compiler/codegen/src/compile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1948,7 +1948,7 @@ impl Compiler<'_> {
// If no name is provided, simply pop the top of the stack.
None => {
emit!(self, Instruction::Pop);
return Ok(());
Ok(())
}
Some(name) => {
// Check if the name is forbidden for storing.
Expand Down
2 changes: 1 addition & 1 deletion compiler/codegen/src/ir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ impl CodeInfo {
let instr_display = instr.display(display_arg, self);
eprint!("{instr_display}: {depth} {effect:+} => ");
}
if effect < 0 && depth < effect.abs() as u32 {
if effect < 0 && depth < effect.unsigned_abs() {
panic!("The stack will underflow at {depth} with {effect} effect on {instr:?}");
}
let new_depth = depth.checked_add_signed(effect).unwrap();
Expand Down
Loading
0