Fix implementation of bytes.isspace to match the implementation in CP…

…ython.
RustPython · hbina · Apr 1, 2025 · Apr 1, 2025 · Apr 1, 2025 · Apr 1, 2025
commit 027f1152bfc8eb97d233d900fb80dbf7595204b7
diff --git a/Lib/test/test_bigmem.py b/Lib/test/test_bigmem.py
@@ -786,17 +786,6 @@ def test_title(self, size):
     def test_swapcase(self, size):
         self._test_swapcase(size)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
-    @bigmemtest(size=_2G, memuse=2)
-    def test_isspace(self, size):
-        super().test_isspace(size)
-
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
-    @bigmemtest(size=_2G, memuse=2)
-    def test_istitle(self, size):
-        super().test_istitle(size)
 
 class BytearrayTest(unittest.TestCase, BaseStrTest):
 
@@ -823,18 +812,6 @@ def test_swapcase(self, size):
     test_hash = None
     test_split_large = None
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
-    @bigmemtest(size=_2G, memuse=2)
-        def test_isspace(self, size):
-        super().test_isspace(size)
-
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
-    @bigmemtest(size=_2G, memuse=2)
-    def test_istitle(self, size):
-        super().test_istitle(size)
-
 class TupleTest(unittest.TestCase):
 
     # Tuples have a small, fixed-sized head and an array of pointers to

diff --git a/extra_tests/snippets/builtin_bytes.py b/extra_tests/snippets/builtin_bytes.py
@@ -668,4 +668,7 @@ def __new__(cls, value):
 b = B1.fromhex('a0a1a2')
 assert b.foo == 'bar'
 
-skip_if_unsupported(3,11,test__bytes__)
+skip_if_unsupported(3,11,test__bytes__)
+
+assert " \f\n\r\t\v".encode("utf-8").isspace()
+assert " \f\n\r\t\v".encode("latin-1").isspace()
diff --git a/vm/src/bytes_inner.rs b/vm/src/bytes_inner.rs
@@ -364,11 +364,18 @@ impl PyBytesInner {
     }
 
     pub fn isspace(&self) -> bool {
+        // What CPython considers whitespace is a bit different from what Rust.
+        // In particular, Rust does not consider vertical tabulation (\x0B) to be a whitespace.
+        // See https://docs.python.org/3/library/stdtypes.html#bytearray.isspace
+        // See https://doc.rust-lang.org/std/primitive.char.html#method.is_ascii_whitespace
+        // Note that str.isspace uses a different definition too.
+        // See https://docs.python.org/3/library/stdtypes.html#str.isspace
         !self.elements.is_empty()
             && self
                 .elements
                 .iter()
-                .all(|x| char::from(*x).is_ascii_whitespace())
+                .map(|c| char::from(*c))
+                .all(|c| c.is_ascii_whitespace() || c == '\x0b')
     }
 
     pub fn istitle(&self) -> bool {