8000 Windows installer via cargo-packager by arihant2math · Pull Request #5549 · RustPython/RustPython · GitHub
[go: up one dir, main page]

Skip to content

Windows installer via cargo-packager #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

arihant2math
Copy link
Collaborator

No description provided.

@arihant2math
Copy link
Collaborator Author

I'm trying to find a clean way to get nsis to have an add to path option.

Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@arihant2math arihant2math marked this pull request as ready for review February 27, 2025 16:45
@arihant2math
Copy link
Collaborator Author

Atleast a temporary solution that allows for windows packaging with the stdlib included.

@arihant2math
Copy link
Collaborator Author

@coolreader18
Just pinging to bump, since this has went down the stack a bit.

@youknowone
Copy link
Member

@coolreader18 could you review this pr?

Copy link
Member
@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know very little about windows packaging but this looks fine to me.

@youknowone youknowone merged commit 2a41072 into RustPython:main Mar 25, 2025
11 checks passed
@arihant2math arihant2math deleted the windows-msi branch April 1, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0