8000 Update codecs and test_codecs from cpython v3.12.4 by Andrewb12505 · Pull Request #5372 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Update codecs and test_codecs from cpython v3.12.4 #5372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 29, 2024
Merged

Update codecs and test_codecs from cpython v3.12.4 #5372

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
628d8be
updated test_codecs.py from cpython v3.12.4
Andrewb12505 Jul 28, 2024
9424787
updated codecs.py from cpython v3.12.4
Andrewb12505 Jul 28, 2024
5c17c2a
Marked failing tests
Andrewb12505 Jul 28, 2024
47a65e3
Unmarked passing tests
Andrewb12505 Jul 28, 2024
a5e6752
Removed extra whitespace
Andrewb12505 Jul 28, 2024
4f2c99f
marked windows only failed tests
Andrewb12505 Jul 29, 2024
208b26d
corrected mislabeled tests
Andrewb12505 Jul 29, 2024
7f90beb
Apply suggestions from code review
youknowone Jul 29, 2024
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@youknowone
youknowone authored Jul 29, 2024
commit 7f90beb434fc9581182ab9f40b43923a26088451
3 changes: 1 addition & 2 deletions Lib/test/test_codecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,8 +864,7 @@ def test_bug691291(self):
self.addCleanup(os_helper.unlink, os_helper.TESTFN)
with open(os_helper.TESTFN, 'wb') as fp:
fp.write(s)
# TODO: RUSTPYTHON - warnings_helper function not present
# with warnings_helper.check_warnings(('', DeprecationWarning)):
with warnings_helper.check_warnings(('', DeprecationWarning)):
reader = codecs.open(os_helper.TESTFN, 'U', encoding=self.encoding)
with reader:
self.assertEqual(reader.read(), s1)
Expand Down
Loading
0