8000 Check `value` is `PyType` first by moreal · Pull Request #5227 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Check value is PyType first #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

Check value is PyType first #5227

merged 2 commits into from
Apr 15, 2024

Conversation

moreal
Copy link
Contributor
@moreal moreal commented Apr 14, 2024

This pull request continues from #5225 PR. In that PR, I missed to downcast value to PyType type when evaluating both_module value. So cargo run -- --install-pip get-pip was still failed in the same reason.

This pull request downcasts value to PyRef<PyType> when value is module type. Also it checks value is PyType first, once.

This pull request doesn't resolve an issue, get-pip doesn't work, completely. After this pull request, it should bump Lib/shutil to Python 3.12 version's.

@moreal moreal mentioned this pull request Apr 14, 2024
Merged
youknowone
youknowone approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member
@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit 959e7c1 into RustPython:main Apr 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moreal @youknowone
0