8000 Fix Windows CI by derlih · Pull Request #5168 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Fix Windows CI #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 18, 2024
Merged

Fix Windows CI #5168

merged 11 commits into from
Feb 18, 2024

Conversation

derlih
Copy link
Contributor
@derlih derlih commented Feb 16, 2024 •
edited
Loading

Attempt to address #5166

@derlih derlih force-pushed the 5166-fix-windows-ci branch 2 times, most recently from 65c5780 to 44d7887 Compare February 16, 2024 07:49
@derlih derlih force-pushed the 5166-fix-windows-ci branch from 44d7887 to 610ec2a Compare February 16, 2024 07:54
@derlih derlih changed the title pin openssl version for windows CI Fix Windows CI Feb 16, 2024
@derlih derlih force-pushed the 5166-fix-windows-ci branch from 7b77f1a to 0c57fd0 Compare February 17, 2024 10:53
@derlih derlih force-pushed the 5166-fix-windows-ci branch from 1ed8a01 to 60c1c4e Compare February 17, 2024 11:28
@youknowone
Copy link
Member
youknowone commented Feb 17, 2024 •
edited
Loading

Thank you so much! miri failing doesn't look like related.

@derlih
Copy link
Contributor Author
derlih commented Feb 17, 2024

Let me polish it a bit. =)

@derlih derlih force-pushed the 5166-fix-windows-ci branch from 55d09db to f8d531e Compare February 17, 2024 15:08
@derlih
Copy link
Contributor Author
derlih commented Feb 17, 2024

@youknowone can you clean up the build cache from this job?
It doesn't contain SSL build and cargo-vcpkg, but I can't invalidate it in an easy way.

@youknowone
Copy link
Member

Triggered running again after deleting cache

@youknowone
Copy link
Member

The result looks fine

@derlih
Copy link
Contributor Author
derlih commented Feb 18, 2024

But not perfect =)
It uses cached cargo-vcpkg but still compiles OpenSSL from sources.
It takes extra 5 minutes of the Windows build. I though vcpkg will use cached OpenSSL build.

@derlih derlih marked this pull request as ready for review February 18, 2024 16:37
youknowone
youknowone approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member
@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. Working CI is always better than broken one, so let's merge it first.

How about additonally adding vcpkg directory to actions/cache? would it fix it?

@youknowone youknowone merged commit 97a0705 into RustPython:main Feb 18, 2024
@derlih derlih deleted the 5166-fix-windows-ci branch February 19, 2024 07:35
@derlih
Copy link
Contributor Author
derlih commented Feb 19, 2024

The problem is that cargo-vcpkg, vcpkg itself and OpenSSL build are cached by rust-cache action. But I guess after the cache restoration the timestamps from files don't match and that's why it needs to build OpenSSL on each build.

@youknowone
Copy link
Member

Thank you for explanation

@youknowone youknowone mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derlih @youknowone @derlikh-smart
0