8000 Fix bug in `binascii` `uu` encoding. Pass more related unit tests. by kingiler · Pull Request #5160 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Fix bug in binascii uu encoding. Pass more related unit tests. #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix bug in binascii uu encoding. Pass more related unit tests. #5160

merged 2 commits into from
Feb 9, 2024

Conversation

kingiler
Copy link
Contributor
@kingiler kingiler commented Feb 9, 2024 •
edited
Loading
  • Fix logic bug in both binascii.a2b_uu and binascii.b2a_uu.
  • Use correct error type by new_binascii_error instead of new_value_error.
  • Pass three more unit tests: test_uu, test_returned_value and test_unicode_a2b.

[Edit]

  • Pass more related unit tests in test_uu and test_codecs.

@kingiler kingiler changed the title Fix bug in binascii uu encoding. Pass three more unit tests. Fix bug in binascii uu encoding. Pass more related unit tests. Feb 9, 2024
@kingiler
Copy link
Contributor Author
kingiler commented Feb 9, 2024

About CI:
It seems related to compilation of openssl on Windows but I do not have Windows machine accessible. Can anyone help to lookup the issue?

youknowone
youknowone approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member
@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure does not seem to related to this patch. I need to investigate what's happened, but currently not accessible to a windows machine either. Let's ignore it for now.

Thank you for contributing!

@youknowone youknowone merged commit bdf228e into RustPython:main Feb 9, 2024
@kingiler kingiler deleted the binascii branch June 25, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingiler @youknowone
0