Expose a method to parse AST from tokens directly #4229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
reviewed
Oct 17, 2022
compiler/parser/src/parser.rs
Outdated
| @@ -5,9 +5,11 @@ | |||
| //! parse a whole program, a single statement, or a single | |||
| //! expression. | |||
|
|
|||
| use std::iter; | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
we like to depend on formatter than human
compiler/parser/src/parser.rs
Outdated
| @@ -23,6 +25,17 @@ pub fn parse_program(source: &str, source_path: &str) -> Result<ast::Suite, Pars | |||
| }) | |||
| } | |||
|
|
|||
| /// Parse the token stream for a full python program. | |||
| pub fn parse_program_tokens( | |||
There was a problem hiding this comment.
I understand we'd better to add parse_tokens for some use case. But parse_program_tokens too?
This is a very specific use case which can be also covered by parse_program_tokens.
dc4016a to
9ced976
Compare
youknowone
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this in Ruff where it's useful to be able to generate the token stream once upfront, use it in a few places, then pass it to the parser without re-tokenizing the entire stream.