8000 add IMMUTABLE flag and set non-heaptype as immutable by lijm1358 · Pull Request #3821 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

add IMMUTABLE flag and set non-heaptype as immutable #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add IMMUTABLE flag and set non-heaptype as immutable #3821

wants to merge 1 commit into from

Conversation

lijm1358
Copy link
Contributor
@lijm1358 lijm1358 commented Jun 26, 2022 •
edited
Loading
  • as PyType_Ready() sets Py_TPFLAGS_IMMUTABLETYPE flag if Py_TPFLAGS_HEAPTYPE not set in CPython, add IMMUTABLETYPE flag and set it to non-heaptype.
  • add error message when setting attribution of immutable types
>>>>> int.a = 1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: cannot set 'a' attribute of immutable type 'int'
  • but it's not working correctly; some types might be/not be heaptype in CPython
>>>>> import io
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "D:\RustPython\Lib\io.py", line 83, in <module>
    UnsupportedOperation.__module__ = "io"
TypeError: cannot set '__module__' attribute of immutable type 'UnsupportedOperation'

@lijm1358 lijm1358 closed this Jun 26, 2022
@lijm1358 lijm1358 reopened this Jun 26, 2022
@lijm1358 lijm1358 marked this pull request as draft June 26, 2022 06:52
@lijm1358 lijm1358 changed the title add <code>IMMUTABLE</code> flag and set non-heaptype as immutable add IMMUTABLE flag and set non-heaptype as immutable Jun 26, 2022
@Snowapril
Copy link
Contributor

RustPython has more static type than cpython. Making all static types immutable will leads to such incompatibility in the case of the type which is static type in rustpython and heap type in cpython.

@youknowone
Copy link
Member
youknowone commented Jun 26, 2022 •
edited
Loading

@Snowapril do you know which type is different? Probably we'd better to consider turn them to heap types later.

@Snowapril
Copy link
Contributor
Snowapril commented Jun 26, 2022 •
edited
Loading

@youknowone It seems built-in types are compatible with CPython's.
With a simple python script, I found the below types are different from CPython's.

items rustpython cpython3.10
_thread.LockType static heap
_thread.RLock static heap
_thread._local static heap
_io.UnsupportedOperation static heap
posix.DirEntry static heap
posix.sched_param static heap
posix.stat_result static heap
posix.terminal_size static heap
posix.times_result static heap
posix.uname_result static heap
os.path.DirEntry static heap
os.path.sched_param static heap
os.path.stat_result static heap
os.path.terminal_size static heap
os.path.times_result static heap
os.path.uname_result static heap
os.DirEntry static heap
os.sched_param static heap
os.stat_result static heap
os.terminal_size static heap
os.times_result static heap
os.uname_result static heap

@fanninpm
Copy link
Contributor

@Snowapril are you able to share that script? I think it would make a fine addition to our CI suite.

@Snowapril Snowapril mentioned this pull request Jul 6, 2022
Open
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lijm1358 @Snowapril @youknowone @fanninpm
0