8000 Final demo improvements by coolreader18 · Pull Request #245 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Final demo improvements #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Dec 29, 2018
Merged

Final demo improvements #245

merged 29 commits into from
Dec 29, 2018

Conversation

coolreader18
Copy link
Member

The final stage (in theory) of #238. This is a new branch split off of master just now, so no merge conflicts. I'd still like to add a few™ more things (Cargo.toml fields maybe), but then this should be done.

@coolreader18
Rearrange website directory and change webpack config
03c619f
@coolreader18
Switch to using one workspace, move profile to root Cargo.toml
4c32693
@coolreader18
Genericize the wasm lib to not be specifically for the demo
ca30ebc 
This included changing RustObjectKind::RustFunction.function to be
a `Box<Fn()>` instead of a `fn()` to support closures.
@coolreader18
Add example, change some stuff in the demo to align with example
2ea9dca
@coolreader18
Make scripts executable
d54d2b1
@coolreader18
Improve UX for demo
840c507
@coolreader18
Use str.format for the demo
ab23f2c
@coolreader18
Re-add conflicting files
24507de
@coolreader18
Remove conflicting files
ffcd40b
@coolreader18
Change the instances of Fn(..) -> PyResult to a RustPyFunc trait alias
d1d9585
@coolreader18
Fix blanket impl of RustPyFunc
63b3f3e
@coolreader18
Allow passing closures from JS to python via vars
132930e
@coolreader18
Implement error conversion for js_to_py
e0959b9
@coolreader18
Fix js_to_py with JS undefined
94d6a91
@coolreader18
Add some documentation for functions on the demo site
c38796b
@coolreader18
Switch from shell to npm scripts for demo using webpack and @wasm-too…
877206d 
…l/wasm-pack-plugin

Also change travis deploy to use new demo directory.
@coolreader18
Change README portion for compiling wasm
2968982
@coolreader18
Add conflicting files
ada92d3
@coolreader18
Remove (now outdated) previously conflicting files
dfadd03
@coolreader18
Readd conflicting files
396842e
@coolreader18
Remove RustPyFunc trait, just use Fn(..) everywhere
8303743
@coolreader18
Squash all demo commits onto one branch
1f02cc0
@coolreader18 coolreader18 mentioned this pull request Dec 28, 2018
Closed
@windelbouwman windelbouwman merged commit d425c26 into RustPython:master Dec 29, 2018
@windelbouwman
Copy link
Contributor

Thank you for your contribution!

@coolreader18 coolreader18 deleted the final-demo-improvements branch December 29, 2018 17:25
@coolreader18
Copy link
Member Author
coolreader18 commented Dec 30, 2018 •
edited
Loading

Thanks for merging this! One last thing, would you mind pushing to the release branch? Thanks! Also, sorry for not squashing the commits, I was following a StackOverflow post and I thought what they suggested would do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @windelbouwman
0