8000 Limit the gh-pages deployment step to only nightly build by shinglyu · Pull Request #208 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Limit the gh-pages deployment step to only nightly build #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

Limit the gh-pages deployment step to only nightly build #208

merged 1 commit into from
Dec 4, 2018

Conversation

shinglyu
Copy link
Contributor

@windelbouwman this should fix the python tests

windelbouwman
windelbouwman reviewed Nov 26, 2018
View reviewed changes
.travis.yml Outdated
@@ -14,6 +14,7 @@ script:
env:
# This is used to only capture the regular nightly test in allow_failures
- REGULAR_TEST=true
- PUBLISH_DOC=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we inverse the logic here by setting the variable to true at one matrix item, and leaving it unspecified otherwise? This was we can mark what where we want to publish the docs more clearly. In other words, change this variable to false and mark the build that must publish the docs as true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@shinglyu shinglyu force-pushed the travis-fix branch 2 times, most recently from 1209949 to b73618b Compare December 3, 2018 18:56
@shinglyu
Copy link
Contributor Author
shinglyu commented Dec 3, 2018

I can't set the it in the env section, otherwise the matrix will be expended for every kind of job. So instead I created a new job in the matrix.include to just build the doc and deploy. I built it with nightly rust, maybe we should use stable instead? @windelbouwman ?

@windelbouwman
Copy link
Contributor

I would propose to use stable rust release version. RustPython itself already is unstable enough ;)

@windelbouwman windelbouwman merged commit 30bb111 into master Dec 4, 2018
@windelbouwman windelbouwman deleted the travis-fix branch February 15, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windelbouwman windelbouwman windelbouwman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinglyu @windelbouwman
0