Added call_or_unsupported to vm.rs #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent code duplication
Contributor
Author
|
How to write tests to make sure this is working correctly? I would need to catch exception |
Contributor
|
You could write rust unit tests, but in this case it might be better to write a python test snippet which catches the exception and tests if the proper exception is raised. You could use try-except-else for this, like is done here: https://github.com/RustPython/RustPython/blob/master/tests/snippets/builtin_hex.py |
Collaborator
|
Sorry about being slow to respond to this. I'd prefer to see this named something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent code duplication. Based on #188