8000 Fix test_bool::test_sane_len by youknowone · Pull Request #1676 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Fix test_bool::test_sane_len #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fix test_bool::test_sane_len #1676

merged 1 commit into from
Jan 28, 2020

Conversation

youknowone
Copy link
Member

No description provided.

@youknowone
Copy link
Member Author

The result is wierd

test_sane_len (test.test_bool.BoolTest) ... unexpected success

This test is not marked as expectedFailure but doesn't show ok. It is success on my local machine so not easy to dig in.

@youknowone
Copy link
Member Author

@palaviv do you have any idea about this?

@youknowone youknowone requested a review from palaviv January 12, 2020 09:43
@palaviv
Copy link
Contributor
palaviv commented Jan 12, 2020

I am not sure what happens here. This test is flaky. I think marking the CPython test suite as allowed failed would be the best until we see this passing consistently.

@coolreader18
Copy link
Member

Oh, this might be my fault... I panicked when I pushed a commit to master instead of #1666 so I merged it to master right away, but #1666 had apparently broken a CPython test, so I pushed a commit to master last night to fix it.

@youknowone youknowone force-pushed the fix-cpytest branch 2 times, most recently from c56a230 to 3c532c0 Compare January 14, 2020 06:38
@palaviv
Copy link
Contributor
palaviv commented Jan 17, 2020

@youknowone is this rebased in the latest master?

@youknowone
Copy link
Member Author

I thought so - but it didn't work. trying again

@youknowone youknowone force-pushed the fix-cpytest branch 2 times, most recently from 55c5f3e to d090f40 Compare January 25, 2020 14:19
@palaviv
Copy link
Contributor
palaviv commented Jan 25, 2020

Seems like everything is OK now 😄. Can we close this?

@youknowone youknowone changed the title Fix CPython test error Fix test_bool::test_sane_len Jan 25, 2020
@youknowone
Copy link
Member Author

I found I fixed another test but didn't change the test decorator. yes, please merge and close this

@coolreader18 coolreader18 merged commit e6a431a into RustPython:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palaviv palaviv Awaiting requested review from palaviv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowone @palaviv @coolreader18
0