8000 Don't use proc-macro-hack; use our own slightly-less-hacky hack by coolreader18 · Pull Request #1669 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Don't use proc-macro-hack; use our own slightly-less-hacky hack #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

Don't use proc-macro-hack; use our own slightly-less-hacky hack #1669

merged 1 commit into from
Jan 10, 2020

Conversation

coolreader18
Copy link
Member
@coolreader18 coolreader18 commented Jan 10, 2020 •
edited
Loading

proc-macro-hack is sort of a pain to deal with (based on the nested cargo features that were removed by this), and with Rust 1.40 function-like macros can generate macro_rules!, so this is pretty easy to implement ourselves (proc-macro-hack does something with a custom derive on an enum and stringifying and reparsing the input stream).

palaviv
palaviv approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor
@palaviv palaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The CI is failing on some redundant new line 😞

@coolreader18 coolreader18 force-pushed the coolreader18/no-proc-macro-hack branch from 5a80d49 to 098532b Compare January 10, 2020 17:29
@coolreader18 coolreader18 merged commit bc0baa4 into master Jan 10, 2020
@coolreader18 coolreader18 deleted the coolreader18/no-proc-macro-hack branch January 14, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palaviv palaviv palaviv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @palaviv
0