10000 Refactor list, tuple and collections.deque by youknowone · Pull Request #1655 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Refactor list, tuple and collections.deque #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 8, 2020
Merged

Refactor list, tuple and collections.deque #1655

merged 11 commits into from
Jan 8, 2020

Conversation

youknowone
Copy link
Member
@youknowone youknowone commented Jan 2, 2020 •
edited
Loading
  • their members are now private (removed TODO)
  • refactor cmp functions
  • PyListRef impls -> PyList
  • Fix deque bug for self comparison
  • SimpleSeq impl for cell ref so that the code now are looks like more common rust

@youknowone youknowone force-pushed the refactor-tuple branch 3 times, most recently from db0089e to 7cbaeae Compare January 2, 2020 16:58
@youknowone youknowone changed the title Refactor tuple (WIP) Refactor tuple Jan 6, 2020
@youknowone youknowone changed the title (WIP) Refactor tuple Refactor list, tuple and collections.deque Jan 7, 2020
coolreader18
coolreader18 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member
@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's a lot of changes!

@youknowone youknowone merged commit 2473f8a into RustPython:master Jan 8, 2020
@youknowone youknowone deleted the refactor-tuple branch January 8, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @coolreader18
0