8000 BUG: fix the wind velocity factors usage and better visualization of uniform distributions in Stochastic Classes by kevin-alcaniz · Pull Request #783 · RocketPy-Team/RocketPy · GitHub
[go: up one dir, main page]
Skip to content

BUG: fix the wind velocity factors usage and better visualization of uniform distributions in Stochastic Classes #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 23, 2025
Merged

BUG: fix the wind velocity factors usage and better visualization of uniform distributions in Stochastic Classes #783

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9fe3a37
wind factor bug corrected
kevin-alcaniz Mar 14, 2025
f6efa81
BUG: StochasticModel visualize attributes of a uniform distribution
kevin-alcaniz Mar 15, 2025
04337ab
variable names corrections
kevin-alcaniz Mar 15, 2025
7f551c2
Merge branch 'develop' into develop
kevin-alcaniz Mar 15, 2025
18f8323
Corrections requested by the pylint test
kevin-alcaniz Mar 15, 2025
72c63b4
Merge branch 'develop' of https://github.com/kevin-alcaniz/RocketPy i…
kevin-alcaniz Mar 15, 2025
7c68241
ENH: more intuitive uniform distribution display in StochasticModel
kevin-alcaniz Mar 22, 2025
63b4af1
Merge branch 'develop' into develop
MateusStano Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rocketpy/stochastic/stochastic_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,5 +184,6 @@ def create_object(self):
# get original attribute value and multiply by factor
attribute_name = f"_{key.replace('_factor', '')}"
value = getattr(self, attribute_name) * value
key = f"{key.replace('_factor', '')}"
setattr(self.obj, key, value)
return self.obj
19 changes: 14 additions & 5 deletions rocketpy/stochastic/stochastic_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,11 +514,20 @@
)
elif isinstance(value, tuple):
nominal_value, std_dev, dist_func = value
return (
f"\t{attr.ljust(max_str_length)} "
f"{nominal_value:.5f} ± "
f"{std_dev:.5f} ({dist_func.__name__})"
)
if callable(dist_func) and dist_func.__name__ == "uniform":
mean = (std_dev + nominal_value) / 2
half_range = (std_dev - nominal_value) / 2
return (

Check warning on line 520 in rocketpy/stochastic/stochastic_model.py

View check run for this annotation

Codecov / codecov/patch

rocketpy/stochastic/stochastic_model.py#L518-L520 

Added lines #L518 - L520 were not covered by tests
f"\t{attr.ljust(max_str_length)} "
f"{mean:.5f} ± "
f"{half_range:.5f} ({dist_func.__name__})"
)
else:
return (
f"\t{attr.ljust(max_str_length)} "
f"{nominal_value:.5f} ± "
f"{std_dev:.5f} ({dist_func.__name__})"
)
return None

attributes = {k: v for k, v in self.__dict__.items() if not k.startswith("_")}
Expand Down
0