8000 DEV: adds ruff, removes black, isort and flake8 by Gui-FernandesBR · Pull Request #763 · RocketPy-Team/RocketPy · GitHub
[go: up one dir, main page]
Skip to content

DEV: adds ruff, removes black, isort and flake8 #763

< 8000 summary id="button-60b8f1ced58351ff" class="btn btn-sm btn-primary m-0 ml-0 ml-md-2" > New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 13, 2025
Merged

DEV: adds ruff, removes black, isort and flake8 #763

merged 8 commits into from
Feb 13, 2025

Conversation

Gui-FernandesBR
Copy link
Member

Ruff is significantly faster than other linters. I recommend using this in your vscode.

We should start migrating from pylint to ruff little by little.

Black, isort and flake8 could already be removed from our project whenever we prefer. ruff format should replace them.

This PR only sets up the ruff check command.

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner January 20, 2025 00:12
@codecov Codecov
Copy link
codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.30137% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (83aa20e) to head (6b06a86).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/environment_analysis.py 0.00% 3 Missing ⚠️
rocketpy/prints/aero_surface_prints.py 33.33% 2 Missing ⚠️
rocketpy/stochastic/stochastic_flight.py 0.00% 2 Missing ⚠️
rocketpy/stochastic/stochastic_model.py 77.77% 2 Missing ⚠️
rocketpy/plots/motor_plots.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #763      +/-   ##
===========================================
+ Coverage    76.42%   80.07%   +3.65%     
===========================================
  Files           95       95              
  Lines        11090    11347     +257     
===========================================
+ Hits          8475     9086     +611     
+ Misses        2615     2261     -354

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR
DEV: adds ruff linter to the project
7412ba4 
IMPORTANT -> the ruff formatter is still not working properly
@Gui-FernandesBR
MNT: add ruff-report.txt to .gitignore
f6cce43
@Gui-FernandesBR Gui-FernandesBR changed the title DEV: adds ruff linter DEV: adds ruff, removes black, isort and flake8 Feb 8, 2025
@Gui-FernandesBR Gui-FernandesBR merged commit 80c4fa8 into develop Feb 13, 2025
10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the dev/adds-ruff-linter branch February 13, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gui-FernandesBR Gui-FernandesBR

Labels
None yet
Projects
LibDev Roadmap
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gui-FernandesBR
0