bugfix/AB#87222_ABC-dependency-error-due-to-dashboard-automation-service#2429
Merged
AntoineRelief merged 1 commit into2.x.xfrom Mar 4, 2024
Conversation
…ice fix: service provided error by adding @SkipSelf decorators to the components importing dashboard automation service in order to check the service instance from parents components, where it's set(dashboards) fix: ruleTarget undefined value on switching tabs in SUI fix: incorrectly loaded layers for map settings by checking if dashboardAutomation service is fetchable
AntoineRelief
pushed a commit
that referenced
this pull request
Mar 6, 2024
…-03-06) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json dashboard automation service could create dependency injection issues ([#2429](#2429)) ([225ad11](225ad11)), closes [bugfix/AB#87222](https://github.com/bugfix/AB/issues/87222) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json in web elements, some filters could be removed ([5014636](5014636))
AntoineRelief
pushed a commit
that referenced
this pull request
Apr 29, 2024
…2.11.0-beta.1) (2024-04-29) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add correct display of title in chart preview ([#2206](#2206)) ([c1d7c70](c1d7c70)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json automation to hide layers would not work fine ([062151e](062151e)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json BO resource's subpages not loading fine, and requiring 2x clicks ([#2441](#2441)) ([cc569ce](cc569ce)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json clicking on points when cluster expand should use lat / long of cluster, not lat / long of click ([#2452](#2452)) ([1317299](1317299)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json dashboard automation service could create dependency injection issues ([#2429](#2429)) ([225ad11](225ad11)), closes [bugfix/AB#87222](https://github.com/bugfix/AB/issues/87222) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json drag & drop would not remove tooltips from the dom ([#2451](#2451)) ([e08c9d7](e08c9d7)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json empty heatmap with valueField could make the map fail ([45bbdbf](45bbdbf)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json filter between pages could sometimes be reactivated ([a76e6fe](a76e6fe)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json heatmap can now use opacity parameter ([#2439](#2439)) ([80da23e](80da23e)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json in web elements, some filters could be removed ([5014636](5014636)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json incorrect message error when no access to application ([#2446](#2446)) ([718964f](718964f)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json layers control would not automatically close when used in web component ([4029ca3](4029ca3)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json onDownloadFile not working when seeing record in form ( display mode ) ([#2453](#2453)) ([06323db](06323db)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json possible conflict between reset filter event and add filter event on widget content click ([e7a48ba](e7a48ba)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json shared-date-filter-menu incorrect date format ([#2230](#2230)) ([86bc965](86bc965)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json some layers could be drawn multiple times due to add layer & remove layer automations ([f20f4ea](f20f4ea)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README. 8000 md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add calendar type option to date questions ([#2435](#2435)) ([6518b16](6518b16)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json allow heatmap to have intensity field ([#2437](#2437)) ([027c291](027c291)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json default number of items per page in summary cards now depend by default on height of window ([15072c5](15072c5)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json system now stores selection of page size on summary card widgets, so it can be reused for future widgets ([768ff58](768ff58)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Update Angular packages to v16 ([#2211](#2211)) ([a2ae9e7](a2ae9e7)), closes [#2212](#2212) ### Performance Improvements CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json base case test for ui library ([#2242](#2242)) ([b8ca7ea](b8ca7ea)) ### Reverts CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "fix: add correct display of title in chart preview (#2206)" (#2245) ([b39f3d2](b39f3d2)), closes [#2206](#2206) [#2245](#2245) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "fix: shared-date-filter-menu incorrect date format (#2230)" (#2243) ([6932170](6932170)), closes [#2230](#2230) [#2243](#2243) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "feat: Update Angular packages to v16 (#2211)" (#2222) ([7240f05](7240f05)), closes [#2211](#2211) [#2222](#2222)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: service provided error by adding @SkipSelf decorators to the components importing dashboard automation service in order to check the service instance from parents components, where it's set(dashboards)
fix: ruleTarget undefined value on switching tabs in SUI
fix: incorrectly loaded layers for map settings by checking if dashboardAutomation service is fetchable
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please refer to screenshots below
Screenshots
Opening map settings before fix
Opening map settings after fix
Also fix the error shown on clicking summary card or text card for targetRule
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145