ensure StringObservable.join does not stall #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The final value emission doesn't honor backpressure. You can override setProducer instead and request max if n > 0 from the child. |
Contributor
Author
|
okey doke |
Contributor
Author
|
added backpressure support. That do? |
Member
|
Looks good thanks. |
akarnokd
added a commit
that referenced
this pull request
Jul 12, 2015
ensure StringObservable.join does not stall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringObservable.joinpassed through requests from child subscriber only and instead needed to requestLong.MAX_VALUEof upstream because only emits on completion.@akarnokd I did slightly more than you suggested so that initial request was Long.MAX_VALUE but also decoupled the parent subscriber from further requests from child subscriber.
PR includes unit test that failed on existing code.