8000 use AbstractOnSubscribe for StringObservable.from(InputStream) and from(Reader) by davidmoten · Pull Request #14 · ReactiveX/RxJavaString · GitHub
[go: up one dir, main page]
Skip to content

use AbstractOnSubscribe for StringObservable.from(InputStream) and from(Reader) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Apr 12, 2015
Merged

use AbstractOnSubscribe for StringObservable.from(InputStream) and from(Reader) #14

akarnokd merged 1 commit into from
Apr 12, 2015

Conversation

@davidmoten
Copy link
Contributor
@davidmoten davidmoten commented Apr 10, 2015

This PR uses AbstractOnSubscribe to provide much simpler implementations of StringObservable.from(InputStream) and StringObservable.from(Reader) that support backpressure.

This PR also

akarnokd
akarnokd reviewed Apr 10, 2015
View reviewed changes
src/main/java/rx/internal/operators/OnSubscribeInputStream.java Outdated
Copy link
Member
@akarnokd akarnokd Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only copy if count < size.

Copy link
Contributor Author
@davidmoten davidmoten Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'll adjust

@davidmoten davidmoten mentioned this pull request Apr 10, 2015
Closed
@davidmoten
Copy link
Contributor Author
davidmoten commented Apr 11, 2015

Moved the explicit version issue in build.gradle to #17. This PR may be ok for merge now.

akarnokd
akarnokd reviewed Apr 11, 2015
View reviewed changes
build.gradle Outdated
Copy link
Member
@akarnokd akarnokd Apr 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remained here accidentally.

@davidmoten
Copy link
Contributor Author
davidmoten commented Apr 11, 2015

woops, sorry, fixed.

@akarnokd
Copy link
Member
akarnokd commented Apr 12, 2015

Thanks.

akarnokd added a commit that referenced this pull request Apr 12, 2015
@akarnokd
Merge pull request #14 from davidmoten/use-abstract-onsub
8ad398b 
use AbstractOnSubscribe for StringObservable.from(InputStream) and from(Reader)
@akarnokd akarnokd merged commit 8ad398b into ReactiveX:1.x Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidmoten @akarnokd
0