Wangsets #4
Open
Wangsets #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisTheBrave
commented
Mar 10, 2019
| @@ -0,0 +1,78 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
This is just a re-saved version of external_tileset.json.
The json file is unchanged except I added a wang set and filled in a few tiles for it.
BorisTheBrave
commented
Mar 10, 2019
| @@ -84,7 +90,7 @@ public class Tileset : ITileset, IXmlSerializable | |||
|
|
|||
| public static Tileset FromStream(System.IO.Stream stream) | |||
| { | |||
| using (var reader = new System.IO.StreamReader(stream)) | |||
| using (var reader = new System.IO.StreamReader(stream, System.Text.Encoding.UTF8, true, 1024, true)) | |||
There was a problem hiding this comment.
NB: This is a subtle, user visible, change. But now the behaviour matches between Tileset.FromStream and Map.FromStream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to play around with this feature, so I added it to your library.
I've departed a bit from your conventions. Rather than manually loading WangSet, i'm using XmlSerializer. This is a bit less verbose, imho, and in this case the extra flexibility isn't needed - you can see I successfully round trip a
.tsxfile. Also, chose to match the JSON format rather than the xml one, where they differ.I also moved some code from TmxMap to TmxMisc - imho it makes more sense to keep reading and writing code in parallel. The upshot of this is you can now write .tsx files. I haven't made an official public API for doing so though.