8000 rsx: Fixes by kd-11 · Pull Request #3699 · RPCS3/rpcs3 · GitHub
[go: up one dir, main page]

Skip to content

rsx: Fixes#3699

Merged
kd-11 merged 28 commits intoRPCS3:masterfrom
kd-11:rsx_volatile
Nov 8, 2017
Merged

rsx: Fixes#3699
kd-11 merged 28 commits intoRPCS3:masterfrom
kd-11:rsx_volatile

Conversation

@kd-11
Copy link
Contributor
@kd-11 kd-11 commented Nov 4, 2017

Lots of changes

  • Reimplemented the fragment shader pipeline (partially) and optimized cache access
  • Implement texture data casts where possible (1D <-> 2D)
  • Implement render-to-cubemap [realtime reflections] (still incomplete, but should work most of the time)
  • Fixes for texture size detection using rsx antialias modes
  • Fixes for hanging when using WCB
  • AMD driver bug workaround (ugh)

TODO:

  • Dragon Quest Builders does not show 3D anymore with vulkan
  • Eternal sonata LSD trip
  • Excessive blur in some games (looks like only nvidia is affected)

@Lemiru
Copy link
Lemiru commented Nov 4, 2017

Differences I have found for now:

  1. After Burner Climax:
    Master:
    screen shot 11-01-17 at 03 54 pm
    This PR:
    screen shot 11-04-17 at 04 46 pm
  2. Eternal Sonata:
    Master:
    screen shot 11-04-17 at 04 27 pm
    screen shot 11-04-17 at 04 28 pm
    This PR:
    screen shot 11-04-17 at 04 42 pm
    screen shot 11-04-17 at 04 44 pm
    I noticed that this LSD Sonata thing is only present on Vulkan. Also it aren't always present (propably it appears only in cutscenes and tutorials)

Edit: Everything was tested on clean RPCS3 placed in different folder (so there wasn't any shader cache)

@MarioSonic2987
Copy link
Contributor

Now Grid has correct aspect ratio:

image

@digitaldude555
Copy link

screenshot 1985

Fixed half screen issue of oreimo.

@digitaldude555
Copy link

screenshot 714
Before.
screenshot 1987
After.

@Kravickas
Copy link
Contributor
Kravickas commented Nov 4, 2017

Dirt 1
corrected ratio
obrazek
obrazek


Grid 2
kinda half fixed colors with spam E {rsx::thread} RSX: Could not gather all required surfaces for cubemap generation - NOW
obrazek
BEFORE
bez nazvu

@MarioSonic2987
Copy link
Contributor

image
KH2 has correct bloom.

@Sora3100
Copy link
Sora3100 commented Nov 4, 2017

image
Looks like it fixes the shading on characters in Graces F
image
Doesn't fix half screen issue though or blurry skits or that you still need to delete shader cache every time
image
Blue veil is gone from Vesperia
image
Tales of Xillia character select screen regressed, should be black silhouettes until you select one of them
image
Tales of Xillia 1 and 2 now both have no shadows

@digitaldude555
Copy link
digitaldude555 commented Nov 4, 2017

screenshot 1824
Before.
screenshot 1990
After.
Big improvement.

I was told to stop posting here, kd check donors channel is where I post improvements and regressions.
On second thought go to media, no talking there.

@Xcedf
Copy link
Xcedf commented Nov 4, 2017

Here's the report (deleted cache every time before the test)
Things that were improved
Heavy Rain Demo
Before(Master)
41
After(this PR)
42
Shadow of The Colossus
Before
45
After
46
UFC 2009 Undisputed Demo
Before
50
After
51

And things that regressed
Red Dead Redemption
white faces and shadows are gone
Before
43
After
44
Heavy Rain
menu and some other parts of the game look overblured
Before
39
After
40

@Xcedf
Copy link
Xcedf commented Nov 4, 2017

Another progress
Sonic & All Strars Racing Tranceformed Demo
now shows some render
Before
13
After
12

@Ekaseo
Copy link
Ekaseo commented Nov 4, 2017

Ni No Kuni missing 3D Graphics in overworld
ninokuni

@AniLeo
Copy link
Member
AniLeo commented Nov 4, 2017

@digitaldude555 You can report improvements here unless kd-11 tells you otherwise.

@digitaldude555
Copy link
digitaldude555 commented Nov 4, 2017

Okay thanks ani.
screenshot 880
Before.
screenshot 1994
After

screenshot 763
Before
screenshot 1996
After

Balls are fixed but background turned blue and score text gone.

@Asinin3
Copy link
Contributor
Asinin3 commented Nov 4, 2017

This game now displays at the proper aspect ratio
image

@Mhmmm
Copy link
Mhmmm commented Nov 4, 2017

Yakuza (Ryu ga Gotoku) Ishin/0/Kiwami are still broken 😕

@jjsat
Copy link
Contributor
jjsat commented Nov 4, 2017

master:
grafik
this pr:
grafik

@digitaldude555
Copy link

screenshot 623
Before
screenshot 2021
After

Save to say all LSD graphics games improved.

@alanliu02
Copy link
alanliu02 commented Nov 5, 2017

Also has blur bug in The Trail of the Cold Steel II
Before
before
After
after

Blur fixed using latest version & Shaders deleted

Thanks kd-11

@kd-11
Copy link
Contributor Author
kd-11 commented Nov 5, 2017

I cannot reproduce some of the bugs here. Its my fault for not mentionung this, but shader cache needs to be wiped before using this. I'll bump the shader cache version before this is merged to avoid such issues

@Sora3100
Copy link
Sora3100 commented Nov 5, 2017

My testing was done with the data folder being deleted beforehand, also using nvidia card, someone on discord reported yesterday that he had different results with AMD

@Psycho-A
Copy link
Psycho-A commented Nov 5, 2017

Seems to be fixed #3681 in Silent Hill: Downpour.

@Kojikun1
Copy link
Kojikun1 commented Nov 5, 2017

Nier Replicant - Vulkan
F {rsx::thread} class std::runtime_error thrown: Verification failed (e=0x7e):
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\VKTextureCache.h:57)

kd-11 added 8 commits November 7, 2017 12:19
- In rare cases the driver derefs a nullptr and dies, taking the emulator with it
- From testing, it seems the vram is indeed freed when this happens so its "safe" to continue
- texture_cache: Fix internal size calculation for subresources
- vk: Delay dynamic state updates until just about to draw to ensure no flush has discarded the cb state
- Both backends now generate very similar code
- Do not overwrite logged programs
- facepalm: Do not enable depth comparison mode if masquerading as RGBA color!
- Fix texture cache blit behaviour when src has AA enabled and dst is a blit dst texture with or without AA
-- This requires handling AA resolve by removing a half downscale on multisampled axes

- Return all ones when a vertex attribute is disabled.
-- Some games forget to enable vertex attributes actually needed by the fs
@kd-11
Copy link
Contributor Author
kd-11 commented Nov 7, 2017

@greentop
That bug is different from the earlier depth blur bug (where depth of field is applied incorrectly) and seems to affect texture quality only. I am not sure why that is but since its not reproducible on windows it will be difficult to diagnose right now.

Ni no kuni "regressed" due to how a game bug is being handled. The two options we have are:

  1. correct graphics in shaders that only do add/sub with invalid data and black output in shaders using mul/div
  2. correct graphics in shaders using mul/div and overbright in shaders that use add and likely garbage where sub is used (less likely)

The only "true" solution is to interpret instructions like we do for CPU stuff (hint: performance hit) or generate dynamic shaders after running variable analysis in the cpu which is a huge task and will add on to the problems we already have with the shader cache so I'll leave it as is for now (with overbright menus in some games to avoid generating NaNs from division by 0)

@Kravickas
Copy link
Contributor
Kravickas commented Nov 7, 2017

Pre-macth intro and replays still doesnt work in NHL, but gameplay works, idk why.. its all rendered like gameplay if it work.

Its almost same as before your big FBO fix.

@MarioSonic2987
Copy link
Contributor

image
In Saints Row: The Third, graphics have improved.

@Kojikun1
Copy link
Kojikun1 commented Nov 7, 2017

Nier Replicant - Vulkan - With Write Color Buffers
Is still with this error
F {rsx::thread} class std::runtime_error thrown: Verification failed (e=0x7e):
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\VKTextureCache.h:57)
RPCS3.log.gz

@Marthgun
Copy link
Marthgun commented Nov 7, 2017

using e6c84fe

No difference on Tales of Graces F from my first post, (transparent lines, blurry skits, menu background half black).

RPCS3.log.gz

@tabnk
Copy link
tabnk commented Nov 8, 2017

Virtua Fighter 5 Color issue finally fixed :). Tks

@kd-11 kd-11 changed the title [WIP] rsx: Fixes rsx: Fixes Nov 8, 2017
@kd-11 kd-11 merged commit ed21bb3 into RPCS3:master Nov 8, 2017
@ghost
Copy link
ghost commented Nov 8, 2017

Hi
Tnx To Kd-11 Work FPS In My Games Have Increased Greatly ( + Graphics )!
And One Thing To Report :
After This Commit ( Never Happened Before This Commit , in Before , I Have Passed Through First Cutseen And Walked To The Salon ) In RDR After First Cutseen ( And When You Go Actually In game ) Game Freeze With This Error :
F {rsx:thread} class std: :runtime_error thrown: [attrib buffer ] working buffer not big enough, buffer_length=268435456 allocated=4039168 requested=4237692448 Guard=4194304 Largest_pool=234240 ( in file c:\projects\rpcs3\rpcs3\emu\rsx\d3d12../common/ring_buffer_helper.h:78)

And in One Other Situation , I Was Getted This Error ( Its Almost Impossible To Walk In Game After This Commit ) And This Is It :
F {rsx:thread} class std::runtime_error Thrown Unknown Vertex Base Type 0 (in File Emu\RSX\gcm_enums.cpp:16)
( i Failed in Cathing The RPCS3 Log File Because this Time The Whole Emulator Get Unresponded And I Closed It With End Task So There was No Changelog )

Also , After Downloading ( I Think , Sorry For Not Memorizing It ) The 65xx ( Or 64xx But Higher Chance for 65xx ) RDR Say This Error Almost All Time In The Game :
E {rsx:thread} RSX: Invalid Framebuffer Setup, w=0, h=0
Log For This Error is Also In The Log File ( Because Error Is Still Exist So... ) My Number One Report Had a Connection with This Commit And My #2 Report Was For Kd-11 And Have No Connection With This Commit But It Was For #1 Report Game So I Reported It Here :)
Tnx To All Beautiful Devs of This Awesome Emulator =)

Here is The Link For RPCS3.log :
https://drive.google.com/file/d/17AvwoQEy7OUoShpQXqxVwCLBs-cv6n7u/view?usp=drivesdk

@ghost
Copy link
ghost commented Nov 8, 2017

RPCS3.log.gz
Here is The More Easy Way To Get that ( Sorry Because i Commented With Mobile )

@AniLeo
Copy link
Member
AniLeo commented Nov 8, 2017

@M220 RDR is not a good test scenario, ignore it for now

@Aske1836
Copy link
Aske1836 commented Nov 9, 2017

[T]/
Thanks for the hard work KD-11! Compatibility in about 3 of my games went from ingame to near-perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0