8000 [Reviews Needed] RPCS3 QT by flash-fire · Pull Request #2645 · RPCS3/rpcs3 · GitHub
[go: up one dir, main page]

Skip to content

[Reviews Needed] RPCS3 QT#2645

Merged
118 commits merged intoRPCS3:masterfrom
flash-fire:RPCS3-QT
Jun 4, 2017
Merged

[Reviews Needed] RPCS3 QT#2645
118 commits merged intoRPCS3:masterfrom
flash-fire:RPCS3-QT

Conversation

@flash-fire
Copy link
Contributor
@flash-fire flash-fire commented Apr 6, 2017

Making this PR so we can collect work on converting to Qt in one place.

Please report issues with the build here so that things aren't duplicated.

@mention-bot
Copy link

@flash-fire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xsacha, @yukariin and @Nekotekina to be potential reviewers.

… ignore rpcs3qt.vcxproj and its filters as they're autogenerated by importing the qt project file. But, this helps clean out clutter for now.
@flash-fire
Copy link
Contributor Author
flash-fire commented Apr 7, 2017

Currently, to build the qt portion with visual studio, here's what you do.

Assumptions, you have the Qt visual studio plugin installed as well as Qt. Otherwise, you can download it from Qt's website. We haven't finalized Qt's version for RPCS3 (or I haven't been told one yet), but 5.8 works for me.

  1. Open rpcs3.sln in visual studio
  2. Assuming you have Qt visual studio plugin installed, go to QT5->Open Project File (.pro)
  3. Navigate to rpcs3/rpcs3qt and select the qt .pro file.
  4. Right click the now uploaded project rpcs3qt, and click "Set as Startup Project"

From there, you can build as normally. Ie. Click "build solution."

@hcorion
Copy link
Member
hcorion commented Apr 7, 2017

@flash-fire Perhaps you could add a README.md in the rpcs3/rpcs3-qt folder with the steps you just explained above.

@flash-fire
Copy link
Contributor Author

@hcorion That sounds good. I'm setting up RPCS3 on my Linux VM later today. And, I'll add the readme after I figure out Linux build for this. I don't want to break Linux build when working on windows primarily.

@hcorion
Copy link
Member
hcorion commented Apr 7, 2017

I just tested, and the linux instructions seem to be as easy as:

  1. cd to rpcs3/rpcs3-qt
  2. run qmake ./rpcs3qt.pro
  3. run make
  4. run ./rpcs3-qt to run the gui.

@flash-fire
Copy link
Contributor Author

Thanks for test hcorion. I'll add that soon enough.

For those curious, I have a branch where wxwidgets is completely removed, and rpcs3 compiles (without the rpcs3 project but with the qt project). It's located here. For now, it's probably a novelty. But, once we're ready, it'll become part of the PR.

No Wxwidgets branch

…cmake file. That's the next thing I'm doing. I'll probably need to modify them so it'll take me time to figure out. But, this will build rpcs3qt on linux and build as is with using qt.
Setted up by importing rpcs3Qt project using Qt's visual studio plugin.
…ed elsewhere. Remove the rpcs3qt project file as its now built into the solution and cmake doesn't care about pro files.
@xsacha
Copy link
Contributor
xsacha commented Apr 15, 2017

Cool, glad that it served a purpose and sorry I never got around to finishing that frontend.

flash-fire and others added 10 commits April 15, 2017 15:15
… old way of having zlib. I also added build dependencies to rpcs3qt so you should no longer get link errors on the first clean rebuild.
* Added the view menu with the corresponding elements. Now, the debugger/log are hidden by default. The view menu has a checkbox which you click to show/hide the dock widgets.

* Make log visible by default

* Improve UI by making it into a checkbox that's easier to use.
- cleaned formatting for the post build command
* fix build legit this time i promise
@flash-fire
Copy link
Contributor Author

Yeah. The pro file you made was particularly useful. Using the plugin's convert to qt project broke some things when using it on the main project. So, I remade the rpcs3 project from scratch using that project import..

Megamouse and others added 3 commits April 17, 2017 12:52
* WIP Gamepadsettings
pushbutton Eventhandling missing

* GamepadSettings should work except for cfg Init
Some KeyInputs are missing

* Update padsettingsdialog.h

* Update padsettingsdialog.cpp (#5)

* Update padsettingsdialog.cpp

removed silly tabs

* Update padsettingsdialog.cpp

* GetKeyCode simplified

* rename pad settings to keyboard settings o.O

* rename keyboard setting to input settings
@flash-fire flash-fire mentioned this pull request Apr 17, 2017
5 tasks
flash-fire and others added 6 commits May 25, 2017 17:50
* add vulkan adapterbox and merge with d3d12 box

* fix adapter text on other renderer

* gather render strings

* attempt fix on gamelist row height

* adjust adapter behaviour to new guideline

* Compiler of Peace.

* High critical hit rate.

* Mugi eating strawberries is savage.
* Most of the adjustments are made here.

* fix gamelist rowheight

* fix msg dialog layout and disable_cancel

* cleanup

* fix disable cancle again

* fix debuggerframe buttons and doubleclick
@flash-fire flash-fire changed the title [Polishing and Reviews Needed] RPCS3 QT [Reviews Needed] RPCS3 QT May 27, 2017
flash-fire and others added 13 commits May 26, 2017 23:33
* upgrade Info Boxes

* upgrade file explorer

* refactor GetSettings and SetSettings

* second refactoring

* cleanup

* travis is a grammar nazi

* second travis shenanigans

* third travis weirdo thingy

* travis 4 mega fun

* travis 5 default to def

* finish refactoring for settings
fix gamelist headers
* msgdialog fix 1

* fix zombie infobox
* Add a welcome dialog.

* Add enter to end of file

* i'm an idiot

* last mistake i hope

* sponsored via --> funded by

* RPCS3 does not condone piracy.

* Mega Adjusts

* Ani Adjustments and a few refactorings

* Yay
…his dialog, they can probably use an emulator too.
@ghost ghost merged commit 6cfb184 into RPCS3:master < 4D23 /span> Jun 4, 2017
@ghost
Copy link
ghost commented Jun 4, 2017

I don't like changes in System.cpp, System.h but it can't be helped right now.

@Megamouse
Copy link
Contributor

I did not like the way it handled things in wx.
If you prefer the old way we can change it back. Or do you have another suggestion

@bjakja
Copy link
bjakja commented Jun 4, 2017

The Legend of Heroes Trails of Cold Steel still freezes at start. Another two games I tested - for me works worse then on wx build. Sound is terrible. Thumb of log scrollbar vanish like in previous version.

@flash-fire
Copy link
Contributor Author

I have TOCS and I know I get in game with comparable performance. Only thing I can think of is you don't have Sandybridge option for LLVM. As, without that option. TOCS dies immediately if using LLVM. (I'm on phone so support won't be very good from me, sorry)

@bjakja
Copy link
bjakja commented Jun 4, 2017

On wx build works for me on Sandy Bridge without this option.
On wx i had it changed but after change it steel freezes.
Using vulcan I got in game but on opengl freeze after Falcom.

@BrokenFantasy
Copy link

Trails of Cold Steel II randomly freezes during its startup screens. The few times I managed to get far enough to load my save, the framerate dropped into the single digits... Any advice please?

@flash-fire
Copy link
Contributor Author

Can you guys make a separate issue? This PR is closed and more people will see it then. I personally won't be able to investigate this at all for at least a few days..

@bjakja
Copy link
bjakja commented Jun 8, 2017

Using new QT build i got assert everytime I use Vulcan.
"F {rsx::thread} : class std::runtime_error thrown: Assertion failed! Result is C4650720h
(in file c:\rpcs3\rpcs3\emu\rsx\vk\VKProgramBuffer.h:146)"

@hcorion
Copy link
Member
hcorion commented Jun 8, 2017

@bjakja Please don't hijack issues. Please go to the forums or discord and ask there.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0