8000 Add option to define OpenBLAS version for manylinux Dockerfile_2_28_a… · ROCm/pytorch@79d3bb8 · GitHub
[go: up one dir, main page]

Skip to content

Commit 79d3bb8

Browse files
davsva01fadara01
authored andcommitted
Add option to define OpenBLAS version for manylinux Dockerfile_2_28_aarch64 (pytorch#150106)
Adds optional variable OPENBLAS_VERSION to `.ci/docker/common/install_openblas.sh` used to define which version of OpenBLAS to install. Adds argument to `Dockerfile_2_28_aarch64` image. Pull Request resolved: pytorch#150106 Approved by: https://github.com/aditew01, https://github.com/fadara01, https://github.com/malfet Co-authored-by: Fadi Arafeh <115173828+fadara01@users.noreply.github.com>
1 parent 0770849 commit 79d3bb8

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

.ci/docker/common/install_openblas.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
set -ex
55

66
cd /
7-
git clone https://github.com/OpenMathLib/OpenBLAS.git -b v0.3.29 --depth 1 --shallow-submodules
8-
7+
git clone https://github.com/OpenMathLib/OpenBLAS.git -b "${OPENBLAS_VERSION:-v0.3.29}" --depth 1 --shallow-submodules
98

109
OPENBLAS_BUILD_FLAGS="
1110
NUM_THREADS=128

.ci/docker/manywheel/Dockerfile_2_28_aarch64

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ RUN git config --global --add safe.directory "*"
5858

5959
FROM base as openblas
6060
# Install openblas
61+
ARG OPENBLAS_VERSION
6162
ADD ./common/install_openblas.sh install_openblas.sh
6263
RUN bash ./install_openblas.sh && rm install_openblas.sh
6364

.ci/docker/manywheel/build.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ fi
2727

2828
MANY_LINUX_VERSION=${MANY_LINUX_VERSION:-}
2929
DOCKERFILE_SUFFIX=${DOCKERFILE_SUFFIX:-}
30+
OPENBLAS_VERSION=${OPENBLAS_VERSION:-}
3031

3132
case ${image} in
3233
manylinux2_28-builder:cpu)
@@ -40,6 +41,7 @@ case ${image} in
4041
GPU_IMAGE=arm64v8/almalinux:8
4142
DOCKER_GPU_BUILD_ARG=" --build-arg DEVTOOLSET_VERSION=13 --build-arg NINJA_VERSION=1.12.1"
4243
MANY_LINUX_VERSION="2_28_aarch64"
44+
OPENBLAS_VERSION="v0.3.29"
4345
;;
4446
manylinuxcxx11-abi-builder:cpu-cxx11-abi)
4547
TARGET=final
@@ -109,6 +111,7 @@ tmp_tag=$(basename "$(mktemp -u)" | tr '[:upper:]' '[:lower:]')
109111
DOCKER_BUILDKIT=1 docker build \
110112
${DOCKER_GPU_BUILD_ARG} \
111113
--build-arg "GPU_IMAGE=${GPU_IMAGE}" \
114+
--build-arg "OPENBLAS_VERSION=${OPENBLAS_VERSION}" \
112115
--target "${TARGET}" \
113116
-t "${tmp_tag}" \
114117
$@ \

0 commit comments

Comments
 (0)
0